builld: upgrade to PRBMath V4 and update minimum pragma

.gitmodules

@@ -15,7 +15,7 @@
   path = "lib/prb-contracts"
   url = "https://github.com/PaulRBerg/prb-contracts"
 [submodule "lib/prb-math"]
-  branch = "v3"
+  branch = "v4"
   path = "lib/prb-math"
   url = "https://github.com/PaulRBerg/prb-math"
 [submodule "lib/prb-test"]

.solhint.json

@@ -3,7 +3,7 @@
   "rules": {
     "avoid-low-level-calls": "off",
     "code-complexity": ["error", 9],
-    "compiler-version": ["error", ">=0.8.13"],
+    "compiler-version": ["error", ">=0.8.19"],
     "contract-name-camelcase": "off",
     "const-name-snakecase": "off",
     "func-name-mixedcase": "off",

package.json

@@ -11,8 +11,7 @@
     "url": "https://github.com/sablierhq/v2-core/issues"
   },
   "devDependencies": {
-    "prettier": "^2.8.4",
-    "rimraf": "^4.4.0",
+    "prettier": "^2.8.7",
     "solhint": "^3.4.1"
   },
   "files": [
@@ -24,6 +23,7 @@
   "keywords": [
     "asset-streaming",
     "blockchain",
+    "cryptoasset-streaming",
     "cryptoassets",
     "ethereum",
     "foundry",
@@ -46,7 +46,7 @@
     "build": "forge build",
     "build:optimized": "FOUNDRY_PROFILE=optimized forge build",
     "build:smt": "FOUNDRY_PROFILE=smt forge build",
-    "clean": "rimraf broadcast cache docs optimized-out out",
+    "clean": "rm -rf broadcast cache docs optimized-out out",
     "gas:report": "forge test --gas-report --match-path \"./test/{fuzz,unit}/**/*.sol\" --no-match-test \"test(Fuzz)?_RevertWhen_\\w{1,}?\"",
     "gas:snapshot": "forge snapshot --match-path \"./test/{fuzz,unit}/**/*.sol\" --no-match-test \"test(Fuzz)?_RevertWhen_\\w{1,}?\"",
     "gas:snapshot:optimized": "pnpm build:optimized && FOUNDRY_PROFILE=test-optimized forge snapshot --match-path \"./test/{fuzz,unit}/**/*.sol\" --no-match-test \"test(Fork)?(Fuzz)?_RevertWhen_\\w{1,}?\"",

remappings.txt

@@ -6,4 +6,3 @@ erc3156/=lib/ERC3156/contracts/
 forge-std/=lib/forge-std/src/
 solarray/=lib/solarray/src/
 solidity-generators/=lib/solidity-generators/src/
-src/=src/

script/bootstrap/BootstrapProtocol.s.sol

@@ -8,10 +8,10 @@ import { UD60x18, ud } from "@prb/math/UD60x18.sol";
 import { Script } from "forge-std/Script.sol";
 import { Solarray } from "solarray/Solarray.sol";
 
-import { ISablierV2Comptroller } from "src/interfaces/ISablierV2Comptroller.sol";
-import { ISablierV2LockupDynamic } from "src/interfaces/ISablierV2LockupDynamic.sol";
-import { ISablierV2LockupLinear } from "src/interfaces/ISablierV2LockupLinear.sol";
-import { Broker, LockupLinear, LockupDynamic } from "src/types/DataTypes.sol";
+import { ISablierV2Comptroller } from "../../src/interfaces/ISablierV2Comptroller.sol";
+import { ISablierV2LockupDynamic } from "../../src/interfaces/ISablierV2LockupDynamic.sol";
+import { ISablierV2LockupLinear } from "../../src/interfaces/ISablierV2LockupLinear.sol";
+import { Broker, LockupLinear, LockupDynamic } from "../../src/types/DataTypes.sol";
 
 import { BaseScript } from "../shared/Base.s.sol";
 

src/SablierV2Comptroller.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BUSL-1.1
-pragma solidity >=0.8.18;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { UD60x18 } from "@prb/math/UD60x18.sol";

src/SablierV2LockupDynamic.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BUSL-1.1
-pragma solidity >=0.8.18;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { SafeERC20 } from "@openzeppelin/token/ERC20/utils/SafeERC20.sol";

src/SablierV2LockupLinear.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BUSL-1.1
-pragma solidity >=0.8.18;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { SafeERC20 } from "@openzeppelin/token/ERC20/utils/SafeERC20.sol";

src/SablierV2NFTDescriptor.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: UNLICENSED
-pragma solidity >=0.8.18;
+pragma solidity >=0.8.19;
 
 import { IERC721Metadata } from "@openzeppelin/token/ERC721/extensions/IERC721Metadata.sol";
 import { ISablierV2NFTDescriptor } from "./interfaces/ISablierV2NFTDescriptor.sol";

src/abstracts/Adminable.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IAdminable } from "../interfaces/IAdminable.sol";
 import { Errors } from "../libraries/Errors.sol";

src/abstracts/NoDelegateCall.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { Errors } from "../libraries/Errors.sol";
 

src/abstracts/SablierV2Base.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BUSL-1.1
-pragma solidity >=0.8.18;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { SafeERC20 } from "@openzeppelin/token/ERC20/utils/SafeERC20.sol";

src/abstracts/SablierV2FlashLoan.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BUSL-1.1
-pragma solidity >=0.8.18;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { SafeERC20 } from "@openzeppelin/token/ERC20/utils/SafeERC20.sol";

src/abstracts/SablierV2Lockup.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BUSL-1.1
-pragma solidity >=0.8.18;
+pragma solidity >=0.8.19;
 
 import { ERC721 } from "@openzeppelin/token/ERC721/ERC721.sol";
 import { IERC721Metadata } from "@openzeppelin/token/ERC721/extensions/IERC721Metadata.sol";

src/interfaces/IAdminable.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 /// @title IAdminable
 /// @notice Contract module that provides a basic access control mechanism, with an admin that can be

src/interfaces/ISablierV2Base.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { UD60x18 } from "@prb/math/UD60x18.sol";

src/interfaces/ISablierV2Comptroller.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { UD60x18 } from "@prb/math/UD60x18.sol";

src/interfaces/ISablierV2Lockup.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { IERC721Metadata } from "@openzeppelin/token/ERC721/extensions/IERC721Metadata.sol";

src/interfaces/ISablierV2LockupDynamic.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 

src/interfaces/ISablierV2LockupLinear.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 

src/interfaces/ISablierV2NFTDescriptor.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BUSL-1.1
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IERC721Metadata } from "@openzeppelin/token/ERC721/extensions/IERC721Metadata.sol";
 

src/interfaces/hooks/ISablierV2LockupRecipient.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 /// @title ISablierV2LockupRecipient
 /// @notice Interface for recipient contracts capable of reacting to cancellations, renouncements, and withdrawals.

src/interfaces/hooks/ISablierV2LockupSender.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 /// @title ISablierV2LockupSender
 /// @notice Interface for sender contracts capable of reacting to cancellations.

src/libraries/Errors.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { UD60x18 } from "@prb/math/UD60x18.sol";

src/libraries/Helpers.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BUSL-1.1
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { UD60x18, ud } from "@prb/math/UD60x18.sol";
 

src/types/DataTypes.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 import { IERC20 } from "@openzeppelin/token/ERC20/IERC20.sol";
 import { UD2x18 } from "@prb/math/UD2x18.sol";

src/types/Math.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 // This file simply re-exports all PRBMath types needed in v2-core. It is provided for convenience so
 // that users don't have to install PRBMath separately.

src/types/Tokens.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.13;
+pragma solidity >=0.8.19;
 
 // This file simply re-exports all token interfaces needed in v2-core. It is provided for convenience so
 // that users don't have to install OpenZeppelin's contracts library separately.

test/fork/lockup/dynamic/Dynamic.t.sol

@@ -98,7 +98,7 @@ abstract contract Dynamic_Fork_Test is Fork_Test {
     /// - It may cancel the stream
     /// - It may emit a {CancelLockupStream} event
     ///
-    /// The fuzzing ensures that all of the following scenarios are tested:
+    /// Given enough test runs, all of the following scenarios will be fuzzed:
     ///
     /// - Multiple values for the funder, recipient, sender, and broker
     /// - Multiple values for the total amount
@@ -119,7 +119,7 @@ abstract contract Dynamic_Fork_Test is Fork_Test {
 
         // Fuzz the segment amounts and calculate the create amounts (total, deposit, protocol fee, and broker fee).
         Vars memory vars;
-        (vars.totalAmount, vars.createAmounts) = fuzzSegmentAmountsAndCalculateCreateAmounts({
+        (vars.totalAmount, vars.createAmounts) = fuzzDynamicStreamAmounts({
             upperBound: uint128(initialHolderBalance),
             segments: params.segments,
             protocolFee: params.protocolFee,

test/fork/lockup/linear/Linear.t.sol

@@ -96,7 +96,7 @@ abstract contract Linear_Fork_Test is Fork_Test {
     /// - It may cancel the stream
     /// - It may emit a {CancelLockupStream} event
     ///
-    /// The fuzzing ensures that all of the following scenarios are tested:
+    /// Given enough test runs, all of the following scenarios will be fuzzed:
     ///
     /// - Multiple values for the the sender, recipient, and broker
     /// - Multiple values for the total amount

test/fuzz/flash-loan/flash-fee/flashFee.t.sol

@@ -6,7 +6,7 @@ import { UD60x18, ud } from "@prb/math/UD60x18.sol";
 import { FlashLoan_Fuzz_Test } from "../FlashLoan.t.sol";
 
 contract FlashFee_Fuzz_Test is FlashLoan_Fuzz_Test {
-    /// @dev The fuzzing ensures that all of the following scenarios are tested:
+    /// @dev Given enough test runs, all of the following scenarios will be fuzzed:
     ///
     /// - Multiple values for the comptroller flash fee, including zero
     /// - Multiple values for the flash loan amount, including zero