Vcard convert #505
Vcard convert #505
Conversation
|
|
||
| } | ||
|
|
||
| $response->setBody($newBody); |
There was a problem hiding this comment.
In case no case above matches, this var will be undefined
There was a problem hiding this comment.
This is true, but that path can also never be taken in the source. I could remove the is_null($result) and add the default : clause though.
| */ | ||
| public function httpAfterGet(RequestInterface $request, ResponseInterface $response) { | ||
|
|
||
| if (strpos($response->getHeader('Content-Type'),'text/vcard')===false) { |
There was a problem hiding this comment.
This will not work for vcard+json
There was a problem hiding this comment.
This is true.. The assumption as of right now is that Sabre\CardDAV\Card always emits plain-old vcard blobs. This is sort of the assumption everywhere, including the backend classes.
The only 'layer' where there may be other formats, is the Plugin. The plugin is responsible to convert from and to jCard (and in the future xCard).
It will do this with incoming cards and here with outgoing cards. I can see myself wanting to also support jCard in the node/backend side in the future, but it's not the case yet.
So for now, it's just a conversion layer. Nothing changes for the implementer.
Work in progress.
GETPUTREPORT