Fix for issue #16. Parsing urls that are only a fragment.

sabre-io · Feb 20, 2017 · dd4fe3a · dd4fe3a
1 parent a0ccf56
commit dd4fe3a
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/lib/functions.php b/lib/functions.php
@@ -333,11 +333,11 @@ function($matches) {
     }
 
     // Taking off a fragment part
-    if (strpos($uri, '#')) {
+    if (strpos($uri, '#')!==false) {
         list($uri, $result['fragment']) = explode('#', $uri, 2);
     }
     // Taking off the query part
-    if (strpos($uri, '?')) {
+    if (strpos($uri, '?')!==false) {
         list($uri, $result['query']) = explode('?', $uri, 2);
     }
 

diff --git a/tests/ParseTest.php b/tests/ParseTest.php
@@ -171,6 +171,20 @@ function parseData() {
                     'fragment' => null,
                 ]
             ],
+            // Parial url
+            [
+                '#foo',
+                [
+                    'scheme'   => null,
+                    'host'     => null,
+                    'path'     => null,
+                    'port'     => null,
+                    'user'     => null,
+                    'query'    => null,
+                    'fragment' => 'foo',
+                ]
+
+            ]
 
         ];
 

diff --git a/tests/ResolveTest.php b/tests/ResolveTest.php
@@ -80,7 +80,13 @@ function resolveData() {
                 'http://www.example.org',
                 '#foo',
                 'http://www.example.org/#foo',
-            ]
+            ],
+            // Another fragment test
+            [
+                'http://example.org/path.json',
+                '#',
+                'http://example.org/path.json',
+            ],
 
         ];