Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve replaces path when resolving a fragment #16

Closed
matt-allan opened this issue Feb 19, 2017 · 1 comment
Closed

resolve replaces path when resolving a fragment #16

matt-allan opened this issue Feb 19, 2017 · 1 comment

Comments

@matt-allan
Copy link
Contributor

matt-allan commented Feb 19, 2017

\Sabre\Uri\resolve('http://www.mydomain.com/somewhere.json', '#');

Expected output:

http://www.mydomain.com/somewhere.json

(or http://www.mydomain.com/somewhere.json#

Actual Output:

http://www.mydomain.com/#

This seems to be because Sabre\Uri\parse('#') returns "path" => "#".

parse_url('#') returns []. It looks like _parse_fallback is returning the path as #.

@matt-allan
Copy link
Contributor Author

Thanks @evert!

evert added a commit that referenced this issue Feb 20, 2017
Fix for issue #16. Parsing urls that are only a fragment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant