Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx PHP-Style and travis #167

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 12, 2019

  • apply pretty ci style fixes
  • get travis green

@DeepDiver1975 DeepDiver1975 changed the title FIx PHP-Style FIx PHP-Style and travis Aug 12, 2019
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/bring-ci-back-into-shape-2.1 branch from 0cb7783 to bcdd8ef Compare August 12, 2019 07:00
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/bring-ci-back-into-shape-2.1 branch from bcdd8ef to 6693aa9 Compare August 12, 2019 07:03
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #167 into 2.1 will increase coverage by <.01%.
The diff coverage is 99.13%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.1     #167      +/-   ##
============================================
+ Coverage     97.48%   97.49%   +<.01%     
  Complexity      112      112              
============================================
  Files            13       13              
  Lines           438      439       +1     
============================================
+ Hits            427      428       +1     
  Misses           11       11
Impacted Files Coverage Δ Complexity Δ
lib/Writer.php 100% <100%> (ø) 19 <19> (ø) ⬇️
lib/Serializer/functions.php 100% <100%> (ø) 0 <0> (ø) ⬇️
lib/ContextStackTrait.php 100% <100%> (ø) 2 <2> (ø) ⬇️
lib/Service.php 100% <100%> (ø) 18 <18> (ø) ⬇️
lib/Element/Cdata.php 100% <100%> (ø) 2 <2> (ø) ⬇️
lib/LibXMLException.php 100% <100%> (ø) 2 <2> (ø) ⬇️
lib/Reader.php 99.11% <100%> (ø) 43 <43> (ø) ⬇️
lib/Element/Uri.php 100% <100%> (ø) 3 <3> (ø) ⬇️
lib/Element/XmlFragment.php 100% <100%> (ø) 14 <14> (ø) ⬇️
lib/Element/Elements.php 100% <100%> (ø) 3 <3> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1907d...ae5e9d5. Read the comment docs.

@DeepDiver1975 DeepDiver1975 requested review from staabm and evert and removed request for staabm August 12, 2019 07:19
@DeepDiver1975 DeepDiver1975 self-assigned this Aug 12, 2019
@staabm
Copy link
Member

staabm commented Aug 12, 2019

Lgtm

@DeepDiver1975 DeepDiver1975 merged commit 49c1b91 into 2.1 Aug 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/bring-ci-back-into-shape-2.1 branch August 12, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants