Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetManager does not check if residues and targets have same length (for residue_to_class) #24

Closed
SebieF opened this issue Jun 24, 2022 · 0 comments · Fixed by #33
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SebieF
Copy link
Collaborator

SebieF commented Jun 24, 2022

Currently, the TargetManager only reads the sequences and labels, so we have a number of residues and a number of labels in the end. If their count does not match (e.g. SEQSEQ, 11101), there is no error thrown in the TargetManager class. The error is then thrown of course in the loss calculation, where prediction and y dimensions have to match.

Of course one could argue that the user is responsible to hand over correct datasets, but it would be nice to throw an appropriate error message for better comprehension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant