Some improvements of the logLik method #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is an implementation of the logLik method of base R, and the base method does not print anything except by the print method of its return value of class 'logLik', I think this method should also not do printing on its own. Therefore this commit removes the corresponding code. Also, it is unconventional that the logLik method modifies its argument in-place if the requested value is not present. Therefore, this commit adds an option to turn this off. The commented out code after the comment "OR: .." was used to provide the alternative, which is giving a message and not returning anything. In the seealso section, links to the functions that can be used to add these missing likelihoods were added.
As per e-mail discussion of today. Please review. Not tested.
|
Any comments on this PR? I added some simple tests, and also a test setup script creating a basic SaemixObject that can also be used in other tests. The setup script will automatically be run (due to its name and location) by testthat. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is an implementation of the logLik method of base R, and the
base method does not print anything except by the print method of its
return value of class 'logLik', I think this method should also not do any
printing on its own. Therefore this commit removes the corresponding
code.
Also, it is unconventional that the logLik method modifies its argument
in-place if the requested value is not present. Therefore, this commit
adds an option to turn this off. The commented out code after the
comment "OR: .." was used to provide the alternative, which is giving a
message and does not return anything.
In the seealso section, links to the functions that can be used to
add these missing likelihoods were added. In roxygen comments,
simple brackets can be used to specify those links which is much
more readable than
\code{\link{xy}}.Also, match.arg() is used for the 'method' argument for easy argument
matching and validation.