Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise dependencies #48

Closed
gabora opened this issue Jan 25, 2021 · 1 comment
Closed

revise dependencies #48

gabora opened this issue Jan 25, 2021 · 1 comment

Comments

@gabora
Copy link
Member

gabora commented Jan 25, 2021

Hey,
the following dependencies should be revised:
Imports:
doParallel, --- is it compulsory?
readr, (? not sure if really needed)
viper, -- (do we need Dorothea for CARNIVAL? or is it only used for the vignette?)
AnnotationDbi, -- gene name mapping should be done outside carnival, right?
UniProt.ws, -- gene name mapping should be done outside carnival, right?

@ptrairatphisan
Copy link
Collaborator

doParallel is for cluster computing and not compulsory.
viper is needed for running DoRothEA. We used to provide a script/pipeline for input data processing in the early versions but not anymore in the latest version.
readr, AnnotationDbi and UniProt.ws are for reading files and mapping between UniprotID and gene symbols in the early versions. This pipeline was also removed in the latest version.

-- Summary: I believe all of these dependencies can be removed. Nevertheless, please recheck whether the CARNIVAL pipeline is still stable after disable/remove these dependencies --

@enio23 @anikaliu - any additional thoughts/comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants