Extract JWT configuration #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fmrsabino
commented
Apr 15, 2024
fmrsabino
commented
- Extracts the JWT configuration out of the root configuration object into its own configuration object.
- This means that if validation is added to the respective properties, the variables won't be required to be set if the module is not enabled.
- Extracts the JWT configuration out of the root configuration object into its own configuration object. - This means that if validation is added to the respective properties, the variables won't be required to be set if the module is not enabled.
Pull Request Test Coverage Report for Build 8702814313Details
💛 - Coveralls |
iamacook
reviewed
Apr 16, 2024
| import { registerAs } from '@nestjs/config'; | ||
| import { faker } from '@faker-js/faker'; | ||
|
|
||
| export default registerAs('jwt', () => ({ |
There was a problem hiding this comment.
Nit: we could create an interface from the "actual" registerAs to ensure that the signature or the ReturnType is the same.
iamacook
approved these changes
Apr 16, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.