Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol-kit): Rename MasterCopy to singleton #532

Merged
merged 12 commits into from
Sep 14, 2023
Merged

refactor(protocol-kit): Rename MasterCopy to singleton #532

merged 12 commits into from
Sep 14, 2023

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Sep 12, 2023 •
edited
Loading

What it solves

Resolves #494

⚠️ Breaking Changes

protocol-kit

  • Rename isL1SafeMasterCopy to isL1SafeSingleton
old: SafeFactory.create({ ethAdapter, isL1SafeMasterCopy: true })
new: SafeFactory.create({ ethAdapter, isL1SafeSingleton: true })

api-kit

  • Rename type MasterCopyResponse to SafeSingletonResponse
  • Rename method getServiceMasterCopiesInfo() to getServiceSingletonsInfo()

@yagopv
isL1SafeMasterCopy - isL1SingletonCopy
ac4a098
@yagopv
safeMasterCopyAddress - safeMasterCopyAddress
e2df557 
safeMasterCopyAbi - safeMasterCopyAbi
MASTER_COPY_ADDRESS - SINGLETON_ADDRESS
MASTER_COPY_ABI - SINGLETON_ABI
@dasanra dasanra linked an issue Sep 12, 2023 that may be closed by this pull request
Replace MasterCopy with Singleton #494
Closed
@yagopv yagopv marked this pull request as ready for review September 12, 2023 14:48
yagopv and others added 4 commits September 14, 2023 14:54
@yagopv @dasanra
Update packages/protocol-kit/README.md
3225e22 
Co-authored-by: Daniel <25051234+dasanra@users.noreply.github.com>
@yagopv @dasanra
Update packages/api-kit/tests/e2e/getServiceMastercopiesInfo.test.ts
5aaf8f1 
Co-authored-by: Daniel <25051234+dasanra@users.noreply.github.com>
@yagopv
Commit suggestion
6ff13e3
@yagopv
Merge branch 'refactor/rename-mastercopy-to-singleton' of https://git…
927b1e2 
…hub.com/safe-global/safe-core-sdk into refactor/rename-mastercopy-to-singleton
@yagopv yagopv merged commit 873c0d6 into release Sep 14, 2023
15 checks passed
@yagopv yagopv deleted the refactor/rename-mastercopy-to-singleton branch September 14, 2023 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasanra dasanra dasanra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MasterCopy with Singleton
2 participants
@yagopv @dasanra