Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(relay-kit): Add tx service compatibility to Safe4337Pack #836

Merged
merged 19 commits into from
Jun 7, 2024
Merged

feat(relay-kit): Add tx service compatibility to Safe4337Pack #836

merged 19 commits into from
Jun 7, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented May 30, 2024

What it solves

Resolves #825

How this PR fixes it

We are adding support for using SafeOperation responses from the transaction service in the Safe4337Pack

@coveralls
Copy link

coveralls commented May 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9413244101

Details

  • 51 of 57 (89.47%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 77.717%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-kit/src/SafeApiKit.ts 4 5 80.0%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts 24 25 96.0%
packages/relay-kit/src/packs/safe-4337/utils.ts 19 20 95.0%
packages/api-kit/src/utils/safeOperation.ts 1 4 25.0%
Totals Coverage Status
Change from base Build 9367021500: -0.2%
Covered Lines: 764
Relevant Lines: 911
💛 - Coveralls

@yagopv
Merge branch 'development' of https://github.com/safe-global/safe-cor…
a9d3c35 
…e-sdk into feat/add-api-compatibility-to-4337-pack

# Conflicts:
#	packages/api-kit/src/types/safeTransactionServiceTypes.ts
@yagopv
Add moduleAddress to Safe Operations
4ef65b1
@yagopv
Create utils for playgrounds
ac22561
@yagopv yagopv linked an issue May 31, 2024 that may be closed by this pull request
[4337] Add compatibility to convert API received Operations #825
Closed
@yagopv yagopv requested a review from dasanra June 6, 2024 13:05
dasanra
dasanra reviewed Jun 6, 2024
View reviewed changes
playground/utils.ts Outdated Show resolved Hide resolved
@yagopv yagopv merged commit 12acb7e into development Jun 7, 2024
20 checks passed
@yagopv yagopv deleted the feat/add-api-compatibility-to-4337-pack branch June 7, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmjssz tmjssz tmjssz approved these changes

@dasanra dasanra dasanra approved these changes

@leonardotc leonardotc Awaiting requested review from leonardotc

@DaniSomoza DaniSomoza Awaiting requested review from DaniSomoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4337] Add compatibility to convert API received Operations
4 participants
@yagopv @coveralls @tmjssz @dasanra