Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix: close banner only for the session; shift sidebar drawer #4093

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Oct 13, 2022

What it solves

The sidebar needs to shift down when the banner is open.

Also store the closed state in the session storage, not in the local storage.

Screenshot 2022-10-13 at 13 07 26

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 13, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3241804045

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 41.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/PsaBanner/index.tsx 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/SafeListSidebar/style.ts 1 0%
Totals Coverage Status
Change from base Build 3241113817: 0.02%
Covered Lines: 4777
Relevant Lines: 10403

💛 - Coveralls

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I had it working with classes but you nailed it more elegantly. Thank you

@katspaugh katspaugh merged commit f870a52 into dev Oct 13, 2022
@katspaugh katspaugh deleted the fix-banner branch October 13, 2022 11:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants