SignOrExecuteForm child components unmounting before closing

[iamacook]

Bug description

When executing a transaction, after signing, some components within the SignOrExecuteForm unmount due to flag changes.

useImmediatelyExecutable internally checks whether a transaction is pending and during the proposal period, this causes elements to unmount, e.g. the "Execute transaction` checkbox, execution method selector, as well as fee details.

Note: before fixing this, we should consider instead including it in the upcoming refactor of the transaction modal.

Environment

• Browser: Firefox
• Wallet: MetaMask
• Chain: All

Steps to reproduce

Create a transaction and after signing its relay, observe the flicker within the modal.

Expected result

All components remain mouned until the modal closes.

Obtained result

Some components unmount before the modal closes.

Screenshots

[katspaugh]

@iamacook is this still the case in epic-tx-redesign?

[iamacook]

@iamacook is this still the case in epic-tx-redesign?

Yes

[katspaugh]

Seems to be still the case but it doesn't break anything.