Python3 branch does not work with python 3(.5) Fix is here

[remibolcom]

Hi Saffsd,

langid fails on line 167 of langid.py with the very example provided on the front page.
This is because in python3, dividing integers produces a float. The fix is to change line 163 from

nb_numfeats = len(nb_ptc) / len(nb_pc)

to

nb_numfeats = int(len(nb_ptc) / len(nb_pc))

and to change line 167 to this:

nb_ptc = np.array(nb_ptc).reshape(nb_numfeats, len(nb_pc))

This fix should be easy to make.
Thanks.

[saffsd]

Hi remibolcom, thanks for reporting the issue and sorry it has taken me so long to address it. I (strangely) don't seem to be able able to reproduce the issue on either the python3 branch or the master branch. Nonetheless, I take your point and I've updated the master branch accordingly. I hope to delete the python3 branch at some point - the main langid.py classifier in master should be compatible with both python2 and python3.

[kellymarchisio]

FYI, I just got this error using the conda install.

conda create -n wmt18-filtering python=3.6 numpy
source activate wmt18-filtering
conda install -c activisiongamescience langid
langid

Results in:

Traceback (most recent call last): File "/home/kmarc/anaconda3/envs/wmt18-filtering/bin/langid", line 6, in <module> sys.exit(langid.langid.main()) File "/home/kmarc/anaconda3/envs/wmt18-filtering/lib/python3.5/site-packages/langid/langid.py", line 498, in main identifier = LanguageIdentifier.from_modelstring(model, norm_probs = options.normalize) File "/home/kmarc/anaconda3/envs/wmt18-filtering/lib/python3.5/site-packages/langid/langid.py", line 182, in from_modelstring nb_ptc = np.array(nb_ptc).reshape(len(nb_ptc)/len(nb_pc), len(nb_pc)) TypeError: 'float' object cannot be interpreted as an integer

[bm777]

FYI, I just got this error using the conda install.

conda create -n wmt18-filtering python=3.6 numpy source activate wmt18-filtering conda install -c activisiongamescience langid langid

Results in:

Traceback (most recent call last): File "/home/kmarc/anaconda3/envs/wmt18-filtering/bin/langid", line 6, in <module> sys.exit(langid.langid.main()) File "/home/kmarc/anaconda3/envs/wmt18-filtering/lib/python3.5/site-packages/langid/langid.py", line 498, in main identifier = LanguageIdentifier.from_modelstring(model, norm_probs = options.normalize) File "/home/kmarc/anaconda3/envs/wmt18-filtering/lib/python3.5/site-packages/langid/langid.py", line 182, in from_modelstring nb_ptc = np.array(nb_ptc).reshape(len(nb_ptc)/len(nb_pc), len(nb_pc)) TypeError: 'float' object cannot be interpreted as an integer

---

Hi @kellymarchisio ,
You should use the workaround of @remibolcom

This is because in python3, dividing integers produces a float. The fix is to change line 163 from

nb_numfeats = len(nb_ptc) / len(nb_pc)

to

nb_numfeats = int(len(nb_ptc) / len(nb_pc))

and to change line 167 to this:

nb_ptc = np.array(nb_ptc).reshape(nb_numfeats, len(nb_pc))