Trac #29513: sage-spkg: Remove check for executable permission on spk…

…g-install.in script templates

These checks were valuable during the transition from scripts to script
templates, but are now obsolete.

URL: https://trac.sagemath.org/29513
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): Dima Pasechnik

build/bin/sage-spkg

@@ -786,19 +786,6 @@ for script in $WRAPPED_SCRIPTS; do
 
     if [ -f "$script.in" ]; then
         if [ "$USE_LOCAL_SCRIPTS" = "yes" ]; then
-            if [ -x "$script.in" ]; then
-                msg="$script.in should not be marked executable in the build/pkgs directory"
-                if [ "$UNAME" = "CYGWIN" ]; then
-                    # On Cygwin we can't necessarily rely on file permissions
-                    # being sane, so just issue a warning; on other platforms
-                    # this should be enforced as an error
-                    echo >&2 "WARNING: $msg"
-                else
-                    error_msg "$msg"
-                    exit 1
-                fi
-            fi
-
             write_script_wrapper "$(pwd)/$script" "$script_dir"
         else
             if [ ! -x "$script" ]; then