Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citation.pyx: don't return false positives based on path #10129

Closed
jhpalmieri opened this issue Oct 14, 2010 · 6 comments
Closed

citation.pyx: don't return false positives based on path #10129

jhpalmieri opened this issue Oct 14, 2010 · 6 comments

Comments

@jhpalmieri
Copy link
Member

If you build Sage in a path containing "numpy", then get_systems in citation.pyx will think that numpy is used in every command, because it does a regular expression search for "numpy" using full pathnames. The attached patch replaces SAGE_ROOT with an empty string, to avoid such false positives.

To test, move an existing Sage installation to /tmp/numpy/sage-4.6.alpha3/, doctest citation.pyx, apply the patch and doctest again. (Other strings which will trigger a failure: scipy, _libsingular, _flint; see the full list at the top of misc/citation.pyx.)

CC: @mwhansen

Component: misc

Author: John Palmieri

Reviewer: Mike Hansen

Merged: sage-4.6.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/10129

@jhpalmieri
Copy link
Member Author

Attachment: trac_10129-get-systems.patch.gz

@jhpalmieri

This comment has been minimized.

@mwhansen
Copy link
Contributor

comment:2

Looks good to me.

@jdemeyer
Copy link

comment:3

Mike: It would be good to add your real name to the Sage Trac wiki at http://trac.sagemath.org/sage_trac/

@jdemeyer
Copy link

Reviewer: Mike Hansen

@jdemeyer
Copy link

jdemeyer commented Nov 1, 2010

Merged: sage-4.6.1.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants