Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Bidiakis cube graph to common graph database #10307

Closed
sagetrac-mvngu mannequin opened this issue Nov 21, 2010 · 7 comments
Closed

add Bidiakis cube graph to common graph database #10307

sagetrac-mvngu mannequin opened this issue Nov 21, 2010 · 7 comments
Assignees
@jasongrout @rlmill @nathanncohen
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-4.6.2

Comments

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Nov 21, 2010

As the subject says. This is part of the larger project at #9136.

Component: graph theory

Author: Minh Van Nguyen

Reviewer: Nathann Cohen

Merged: sage-4.6.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/10307
@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.6.1 milestone Nov 21, 2010
@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Nov 21, 2010

comment:1

Attachment: trac-10307_bidiakis-cube.patch.gz

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Nov 21, 2010

Author: Minh Van Nguyen

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 24, 2010

comment:2

Hello Minh !!!!

I didn't expect to find anything wrong with the doc, or with the doctests in your patch... And there wasn't ! :-D

I just spotted you were redefining the "is 3-regular" method, which Sage already knows. So here is a one-line patch to add to yours. Afterwards, this ticket is good to go !

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 24, 2010

Reviewer: Nathann Cohen

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 24, 2010

Attachment: trac_10307-smallfix.patch.gz

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Nov 24, 2010

comment:3

Replying to @nathanncohen:

I just spotted you were redefining the "is 3-regular" method, which Sage already knows. So here is a one-line patch to add to yours. Afterwards, this ticket is good to go !

Thank you. Positive review.

@jdemeyer jdemeyer modified the milestones: sage-4.6.1, sage-4.6.2 Nov 25, 2010
@jdemeyer
Copy link

Merged: sage-4.6.2.alpha0

This was referenced Jan 10, 2014
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@rlmill rlmill

@nathanncohen nathanncohen

Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.6.2
Development

No branches or pull requests
2 participants
@jasongrout @jdemeyer