Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vector conjugation #10536

Closed
rbeezer mannequin opened this issue Dec 31, 2010 · 10 comments
Closed

Add vector conjugation #10536

rbeezer mannequin opened this issue Dec 31, 2010 · 10 comments
Assignees
@jasongrout @williamstein
Labels
c: linear algebra p: major / 3 t: enhancement
Milestone
sage-4.7

Comments

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Dec 31, 2010

As for matrices, this method conjugates every element of a vector, by appealing to the conjugate() method of the base ring. This is a prelude to a proper inner product for vectors over the complex numbers.

For the record, making a list of new entries and creating a new vector, is much faster than making a copy and changing it in-place.

To the release manager: apply trac_10536-vector-conjugation-v3.patch only.

CC: @kcrisman

Component: linear algebra

Author: Rob Beezer

Reviewer: Felix Lawrence

Merged: sage-4.7.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/10536
@rbeezer rbeezer mannequin added this to the sage-4.7 milestone Dec 31, 2010
@rbeezer rbeezer mannequin assigned jasongrout and williamstein Dec 31, 2010
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Dec 31, 2010

Attachment: trac_10536-vector-conjugation.patch.gz

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Dec 31, 2010

Author: Rob Beezer

@rbeezer rbeezer mannequin added the s: needs review label Dec 31, 2010
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Dec 31, 2010

comment:2

Parents aren't being preserved correctly. New patch in just a bit.

@rbeezer rbeezer mannequin added s: needs work and removed s: needs review labels Dec 31, 2010
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Dec 31, 2010

comment:3

Attachment: trac_10536-vector-conjugation-v2.patch.gz

This now depends on #10537, so that sparse vectors behave properly once rebuilt after being manipulated.

Depends on #10537

Apply trac_10536-vector-conjugation-v2.patch

@rbeezer rbeezer mannequin added s: needs review and removed s: needs work labels Dec 31, 2010
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jan 24, 2011

comment:5

Attachment: trac_10536-vector-conjugation-v3.patch.gz

A block of doctests slipped through without any output. v3 patch corrects that, and is the only patch necessary to apply.

Apply: trac_10536-vector-conjugation-v3.patch

@sagetrac-flawrence
Copy link
Mannequin

sagetrac-flawrence mannequin commented Mar 10, 2011

comment:6

It makes sense, works, passes doctests, and is well documented. Positive review.

@sagetrac-flawrence

This comment has been minimized.

Sign in to view
@sagetrac-flawrence
Copy link
Mannequin

sagetrac-flawrence mannequin commented Mar 10, 2011

Reviewer: Felix Lawrence

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Mar 10, 2011

comment:8

Hi Felix,

Thanks for the reviews - they are a big help!

Rob

@jdemeyer
Copy link

Merged: sage-4.7.alpha3

@rbeezer rbeezer mannequin mentioned this issue Apr 19, 2011
Closed
@sagetrac-mraum sagetrac-mraum mannequin mentioned this issue May 6, 2011
Closed
This was referenced Apr 19, 2011
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@williamstein williamstein

Labels
c: linear algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.7
Development

No branches or pull requests
3 participants
@jasongrout @williamstein @jdemeyer