Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dead code in matrix/matrix_dense.pyx #10759

Closed
zimmermann6 opened this issue Feb 8, 2011 · 5 comments
Closed

remove dead code in matrix/matrix_dense.pyx #10759

zimmermann6 opened this issue Feb 8, 2011 · 5 comments
Assignees
@jasongrout @williamstein
Labels
c: linear algebra p: minor / 4 t: enhancement
Milestone
sage-4.7.1

Comments

@zimmermann6
Copy link

while trying to improve the coverage of matrix/matrix_dense.pyx,
we noticed with Marc Fuentes that the function
_multiply_classical from that file is dead code.
Indeed, all instances of that function in other files are locally
defined, and it seems impossible to exhibit a test which calls that
function. We therefore propose to remove that dead code.

Indeed, after removing that function, all doctests still pass.

CC: @sagetrac-marc-fuentes @sagetrac-Fuentes

Component: linear algebra

Author: Marc Fuentes, Paul Zimmermann

Reviewer: Nathann Cohen

Merged: sage-4.7.1.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/10759
@zimmermann6 zimmermann6 added this to the sage-4.7 milestone Feb 8, 2011
@zimmermann6
Copy link
Author

Attachment: trac_10759.patch.gz

@zimmermann6
Copy link
Author

Author: Marc Fuentes, Paul Zimmermann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 8, 2011

comment:3

Passes -testall -long, and it's a private method anyway... So I guess it's safe to let it go :-)

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 8, 2011

Reviewer: Nathann Cohen

@jdemeyer jdemeyer modified the milestones: sage-4.7, sage-4.7.1 May 10, 2011
@jdemeyer
Copy link

Merged: sage-4.7.1.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@williamstein williamstein

Labels
c: linear algebra p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-4.7.1
Development

No branches or pull requests
4 participants
@jasongrout @williamstein @jdemeyer @zimmermann6