New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platonic solid constructors scale and translate in the wrong order. #10796
Comments
Attachment: 10796-platonic.patch.gz |
Apply only this patch |
comment:3
Attachment: trac_10796-platonic-and-doc.patch.gz This patch takes Robert's patch and adds documentation to show it works, as well as adding a little so this module is at 100%. Only the documentation needs review, hopefully should be fine. Looks good in the ref manual, should check this out. Followup ticket: There are some multiline plots in this file that do not work in the live documentation because of using slashes to continue lines, which apparently Sphinx doesn't pick up. See #10922. |
This comment has been minimized.
This comment has been minimized.
Reviewer: Karl-Dieter Crisman |
Author: Robert Bradshaw, Karl-Dieter Crisman |
comment:5
The docs look fine to me. |
comment:6
Great. Nice catch, by the way. |
Changed reviewer from Karl-Dieter Crisman to Karl-Dieter Crisman, Robert Bradshaw |
Merged: sage-4.7.alpha5 |
This means that if there is a scale and center argument, the true center is "scaled" away fron the origin.
Apply only attachment: trac_10796-platonic-and-doc.patch
CC: @kcrisman @sagetrac-mvngu
Component: graphics
Author: Robert Bradshaw, Karl-Dieter Crisman
Reviewer: Karl-Dieter Crisman, Robert Bradshaw
Merged: sage-4.7.alpha5
Issue created by migration from https://trac.sagemath.org/ticket/10796
The text was updated successfully, but these errors were encountered: