Update Simon's GP scripts

[JohnCremona]

[See #15608 for a list of open simon_two_descent tickets]

Denis Simon has new versions of his scripts (see http://www.math.unicaen.fr/~simon/), these should be updated (see src/ext/pari/simon).

Depends on #11230
Depends on #11234
Depends on #11130
Depends on #15483

CC: @williamstein @pjbruin

Component: elliptic curves

Keywords: simon_two_descent spkg

Author: Peter Bruin

Branch/Commit: 24b6fe9

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/11005

[JohnCremona]

Attachment: trac_11005-simon-sage.patch.gz

applies to 4.7.alpha1

[JohnCremona]

applies to 4.7.alpha1

[JohnCremona]

comment:1

Attachment: trac_11005-simon-extcode.patch.gz

[JohnCremona]

comment:2

Note to reviewers. It is very likely that you will find elliptic curves where the scripts do not work (I have some of my own). That is not a reason to reject this enhancement. The scripts are not perfect, but they are all we have over number fields! As a result of this ticket, we get both updated version of the scripts (with some bug-fixes and enhancements) and also faster execution. But not perfection.

[JohnCremona]

comment:3

Not yet ready for review: still testing.

[JohnCremona]

Attachment: simon-20110321.spkg.gz

New spkg

[sagetrac-mraum]

comment:5

I created a new spkg and I updated the way to update import the library, removing one GP-script from the spkg.
I can give this a positive review, but before someone needs to test this on Mac at least.

[sagetrac-mraum]

comment:6

Attachment: trac-11005-simon-sage-2.patch.gz

[JohnCremona]

comment:7

Martin, the spkg at http://sage.math.washington.edu/home/mraum/simon-20110321.spkg seems to be identical to my original one, which cannot be right.

[JohnCremona]

Changed keywords from none to simon

[JohnCremona]

Changed author from John Cremona to John Cremona, Martin Raum

[sagetrac-mraum]

comment:8

I checked this, but indeed this is the right package. The point was to update the spkg-install script. The rest of the spkg, I think is perfect. Well, we should incorporate the new scripts that you received by Simon.

[jdemeyer]

Reviewer: Jeroen Demeyer

[vbraun]

Changed branch from u/pbruin/11005-Simon_update to 24b6fe9

[vbraun]

Changed commit from 24b6fe9 to none

[vbraun]

comment:36

Doctest failures on 32-bit

• http://build.sagemath.org/sage/builders/%20%20slow%20Skynet%20cicero%20%28Fedora%2016%20i686%29%20full/builds/20/steps/shell_5/logs/stdio
• http://build.sagemath.org/sage/builders/%20%20slow%20Skynet%20mark%20%28SunOS%205.10-32%29%20full/builds/24/steps/shell_5/logs/stdio

[pjbruin]

Changed dependencies from #11230, #11234, #11130 to #11230, #11234, #11130, #15483

[jdemeyer]

comment:38

The pbori.pyx failure is from #15755.

[jdemeyer]

comment:39

Why the dependency on #15483? Now both these tickets depend on eachother. I would prefer to fix #11005 first (using # 32-bit/# 64-bit) and then do #15483 on top of this.

[jdemeyer]

Commit: 24b6fe9

[jdemeyer]

Changed branch from 24b6fe9 to u/pbruin/11005-Simon_update

[jdemeyer]

New commits:

24b6fe9

Update Denis Simon's GP scripts to versions of 06/04/2011 (ell.gp)

[pjbruin]

comment:42

Replying to @jdemeyer:

Why the dependency on #15483?

Because #15483 is the obvious fix for the problem from comment:36.

Now both these tickets depend on eachother. I would prefer to fix #11005 first (using # 32-bit/# 64-bit) and then do #15483 on top of this.

I thought Git was supposed to make things like this easy. I knew that I made the two tickets depend on each other, of course, and agree that circular dependencies are in abstracto not very nice. However, in this case, what looks like a circular dependency is just a way of saying that the tickets should be merged together; the structure of the Git branches is still linear and easy to understand. Moreover, Git will automatically give the same result independently of the ordering in which the two branches are merged. I don't feel like spending any time on making each of the two tickets pass doctests separately.

I also realise you don't like the patch at #15483, so I will make a bit more propaganda for it.

[vbraun]

Changed branch from u/pbruin/11005-Simon_update to 24b6fe9