Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial typo messes up interact doc #11144

Closed
kcrisman opened this issue Apr 7, 2011 · 12 comments
Closed

trivial typo messes up interact doc #11144

kcrisman opened this issue Apr 7, 2011 · 12 comments

Comments

@kcrisman
Copy link
Member

kcrisman commented Apr 7, 2011

The doc for is_auto_update at this page shows that there is an underscore that is formatting a 'u' incorrectly. Probably this is a one-or-two-character fix, though I haven't checked it out. Most likely someone used `` instead of `?

Apply attachment: 11144_sagenb.patch to sagenb.

CC: @sagetrac-mvngu

Component: notebook

Keywords: notebook

Author: Ivo Hedtke

Reviewer: John Palmieri

Merged: sage-4.7.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/11144

@hedtke
Copy link
Contributor

hedtke commented Jul 19, 2011

comment:1

Attachment: trac_11144.patch.gz

@hedtke hedtke added this to the sage-4.7.1 milestone Jul 19, 2011
@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member

Author: Ivo Hedtke

@jhpalmieri
Copy link
Member

comment:3

You've patched the wrong file, SAGE_ROOT/devel/sage/sage/server/notebook/interact.py. Note that this file says at the top

# This file is part of the OLD Sage notebook and is NOT actively developed,
# maintained, or supported.  As of Sage v4.1.2, all notebook development has
# moved to the separate Sage Notebook project:
#
# http://nb.sagemath.org/

I've posted it instead as a patch for the sagenb project instead: see https://code.google.com/p/sagenb/issues/detail?id=41.

To the release manager: I think we should close this ticket as invalid, since it's for the Sage notebook, not the Sage library. Do not apply the patch here.

@jhpalmieri
Copy link
Member

Changed keywords from none to notebook

@jdemeyer
Copy link

comment:4

Replying to @jhpalmieri:

To the release manager: I think we should close this ticket as invalid, since it's for the Sage notebook, not the Sage library. Do not apply the patch here.

It is still not at all clear to me whether there is even something as a "sagenb project" unfortunately. I will attach a proper sagenb patch.

@jdemeyer
Copy link

Attachment: 11144_sagenb.patch.gz

Patch for SAGENB

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

comment:6

See also #11409 for avoiding people to patch to wrong files.

@jdemeyer
Copy link

comment:7

Replying to @jhpalmieri:

I've posted it instead as a patch for the sagenb project instead: see https://code.google.com/p/sagenb/issues/detail?id=41.

I am waiting for clarification on this situation at http://groups.google.com/group/sage-notebook/browse_thread/thread/5f8ee7606e0d94bd

The patch itself obviously gets positive_review.

@jdemeyer jdemeyer removed this from the sage-4.7.2 milestone Jul 24, 2011
@jdemeyer jdemeyer added this to the sage-4.7.2 milestone Jul 25, 2011
@jdemeyer jdemeyer removed the pending label Jul 25, 2011
@jdemeyer
Copy link

Merged: sage-4.7.2.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants