Remove old notebook files #11409

jdemeyer · 2011-05-31T08:57:48Z

The old Sage notebook (as part of the Sage library) has been superseded by the sagenb spkg. The following files are from the old notebook and should be removed:

$SAGE_ROOT/devel/sage/sage/server/introspect.py
$SAGE_ROOT/devel/sage/sage/server/notebook/*
$SAGE_ROOT/devel/sage/sage/server/simple/*

The following files are duplicated in sagenb but contain some functionality which is not specific to the notebook. At the moment no effort is made to dis-entangle these (but I have made them more uniform)

$SAGE_ROOT/devel/sage/sage/server/misc.py
$SAGE_ROOT/devel/sage/sage/server/support.py

Apply:

cd sage/server && hg remove introspect.py notebook simple && hg commit -m "Trac #11409: Remove old notebook files" # I prefer this shell command to a patch because there are no chances of a merge conflict
attachment: trac_11409-rebased-v2.patch
attachment: 11409_doctest.patch

After applying the patches, running sdist, and then make from scratch, I get the following results:

$ cd $SAGE_ROOT
$ grep -e 'server.simple' -e 'server.notebook' -e 'server.introspect' -R .
Binary file ./devel/sage/.hg/store/data/doc/en/reference/notebook.rst.i matches
Binary file ./devel/sage/.hg/store/data/_m_a_n_i_f_e_s_t.in.i matches
Binary file ./devel/sage/.hg/store/00manifest.d matches
Binary file ./devel/sage-main/.hg/store/data/doc/en/reference/notebook.rst.i matches
Binary file ./devel/sage-main/.hg/store/data/_m_a_n_i_f_e_s_t.in.i matches
Binary file ./devel/sage-main/.hg/store/00manifest.d matches
./local/share/texmf/tex/generic/sagetex/remote-sagetex.dtx:% in \texttt{sage/server/simple/twist.py}.

This proves that the deleted files are no longer referenced (expect for a comment in SageTeX, this has been reported to Dan Drake).

See also #9237, #9552.

Depends on #13794
Depends on #14330

CC: @kiwifb @williamstein @kini

Component: notebook

Author: Jeroen Demeyer

Reviewer: Frédéric Chapoton, Punarbasu Purkayastha

Merged: sage-5.13.beta2

Issue created by migration from https://trac.sagemath.org/ticket/11409

The text was updated successfully, but these errors were encountered:

jdemeyer · 2011-05-31T09:31:39Z

Author: Jeroen Demeyer

jdemeyer · 2011-06-07T15:12:39Z

Patch for local/bin

jdemeyer · 2011-06-07T15:13:47Z

comment:5

Attachment: 11409_scripts.patch.gz

jdemeyer · 2011-06-09T16:56:59Z

Patch for SAGENB

jdemeyer · 2011-06-15T16:12:16Z

comment:12

Attachment: 11409_sagenb.patch.gz

jdemeyer · 2011-06-16T19:08:21Z

comment:13

After applying the patches, running sdist, and then make from scratch, I get the following results:

$ cd $SAGE_ROOT
$ grep -e 'server.simple' -e 'server.notebook' -e 'server.introspect' -R .
Binary file ./devel/sage/.hg/store/data/doc/en/reference/notebook.rst.i matches
Binary file ./devel/sage/.hg/store/data/_m_a_n_i_f_e_s_t.in.i matches
Binary file ./devel/sage/.hg/store/00manifest.d matches
Binary file ./devel/sage-main/.hg/store/data/doc/en/reference/notebook.rst.i matches
Binary file ./devel/sage-main/.hg/store/data/_m_a_n_i_f_e_s_t.in.i matches
Binary file ./devel/sage-main/.hg/store/00manifest.d matches
./local/share/texmf/tex/generic/sagetex/remote-sagetex.dtx:% in \texttt{sage/server/simple/twist.py}.

This proves that the deleted files are no longer referenced (expect for a comment in SageTeX, this has been reported to Dan Drake).

kcrisman · 2011-06-23T03:29:54Z

comment:15

Just as a comment, William made some reference at Sage Days 31 to a deprecation period and that these files were needed to enable people to migrate to the new notebook (not the really new flask notebook, nor the old new notebook, but the medium new separate sagenb notebook, I think). I don't know how accurate that is, but thought I should mention it.

jdemeyer · 2011-06-23T13:15:15Z

comment:16

Replying to @kcrisman:

Just as a comment, William made some reference at Sage Days 31 to a deprecation period and that these files were needed to enable people to migrate to the new notebook (not the really new flask notebook, nor the old new notebook, but the medium new separate sagenb notebook, I think).

How long should we wait then? sagenb has existed at least since sage-4.2, released 25 october 2009 (almost 2 years ago). I think that is sufficient time.

kcrisman · 2011-06-23T13:21:41Z

comment:17

That long, eh?

Anyway, since he mentioned it, I figure it would be worth asking him, since he mentioned it. Being a BDFL has its privileges :)

To be fair, I don't feel like I can review this in any case; it would have to be someone pretty familiar with the mechanics of the change to sagenb. But it would be really nice to take care of this, you are right.

fchapoton · 2013-09-08T07:34:42Z

rebased on 5.12.beta4

fchapoton · 2013-09-08T07:36:05Z

comment:41

Attachment: trac_11409-rebased-v2.patch.gz

I have rebased the patch on 5.12.beta4

I had also to put back the import of alarm and cancel_alarm in server/misc.py

for the bot: apply only trac_11409-rebased-v2.patch

fchapoton · 2013-09-15T07:52:39Z

comment:42

apply only trac_11409-rebased-v2.patch

fchapoton · 2013-10-19T12:41:10Z

comment:43

hello, the bot is green, so there is an opportunity to review this now !

ppurka · 2013-10-28T11:31:40Z

Reviewer: Punarbasu Purkayastha

ppurka · 2013-10-28T11:31:40Z

comment:44

This looks fine to me. Irrespective of what the bot says, it applies just fine to 5.13.beta1. I tested 3D plots, 2D plots, debug() functionality, and interacts, and they are all working.

jdemeyer · 2013-10-28T22:21:27Z

Attachment: 11409_doctest.patch.gz

ppurka · 2013-10-29T00:05:29Z

comment:46

Why didn't the patchbot catch this error earlier? I had only a laptop to run all doctests, so I was expecting the patchbot to report any such problems.

jdemeyer · 2013-10-29T11:12:31Z

comment:47

Replying to @ppurka:

Why didn't the patchbot catch this error earlier? I had only a laptop to run all doctests, so I was expecting the patchbot to report any such problems.

I guess the patchbot doesn't understand the "apply" instruction

cd sage/server && hg remove introspect.py notebook simple && hg commit -m "Trac #11409: Remove old notebook files

ppurka · 2013-10-29T11:14:06Z

comment:48

Sorry, the new patch actually introduces the doctest failure. I still get the old result in my copy of 5.13.beta1.

jdemeyer · 2013-10-29T11:16:43Z

comment:49

Replying to @ppurka:

I still get the old result in my copy of 5.13.beta1.

Did you actually remove the old notebook files?

ppurka · 2013-10-29T12:00:00Z

comment:50

Replying to @jdemeyer:

Did you actually remove the old notebook files?

Thanks! I rechecked everything in the notebook after trying this. It works fine, and also doctests fine.

ppurka · 2013-10-29T12:01:02Z

Changed reviewer from Punarbasu Purkayastha to Frédéric Chapoton, Punarbasu Purkayastha

jdemeyer · 2013-10-31T19:15:55Z

Merged: sage-5.13.beta2

jdemeyer added this to the sage-4.7.1 milestone May 31, 2011

jdemeyer added p: major / 3 labels May 31, 2011

jdemeyer assigned jasongrout May 31, 2011

This comment has been minimized.

Sign in to view

jdemeyer added s: needs review labels Jun 16, 2011

This comment has been minimized.

Sign in to view

jdemeyer assigned jdemeyer and unassigned jasongrout Jul 24, 2011

jdemeyer added this to the sage-5.12 milestone Aug 13, 2013

This comment has been minimized.

Sign in to view

ppurka added s: positive review and removed s: needs review labels Oct 28, 2013

This comment has been minimized.

Sign in to view

jdemeyer added s: needs review and removed s: positive review labels Oct 28, 2013

ppurka added s: positive review and removed s: needs review labels Oct 29, 2013

jdemeyer removed the s: positive review label Oct 31, 2013

jdemeyer closed this as completed Oct 31, 2013

williamstein mentioned this issue Feb 22, 2013

90% doctest coverage thrust metaticket #12024

Closed

This was referenced Apr 3, 2012

Excise MoinMoin #12713

Closed

sage -n is broken in 5.5rc0 #13794

Closed

Fix remaining temporary filename issues (like in animate.py) #13807

Closed

jdemeyer mentioned this issue Jan 15, 2013

Don't use TAB characters for indentation #13899

Closed

Remove old notebook files #11409

Remove old notebook files #11409

Comments

jdemeyer commented May 31, 2011

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jdemeyer commented May 31, 2011

jdemeyer commented Jun 7, 2011

This comment has been minimized.

jdemeyer commented Jun 7, 2011

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jdemeyer commented Jun 9, 2011

This comment has been minimized.

jdemeyer commented Jun 15, 2011

This comment has been minimized.

jdemeyer commented Jun 16, 2011

kcrisman commented Jun 23, 2011

jdemeyer commented Jun 23, 2011

kcrisman commented Jun 23, 2011

This comment has been minimized.

fchapoton commented Sep 8, 2013

This comment has been minimized.

fchapoton commented Sep 8, 2013

fchapoton commented Sep 15, 2013

fchapoton commented Oct 19, 2013

ppurka commented Oct 28, 2013

ppurka commented Oct 28, 2013

jdemeyer commented Oct 28, 2013

This comment has been minimized.

ppurka commented Oct 29, 2013

jdemeyer commented Oct 29, 2013

ppurka commented Oct 29, 2013

jdemeyer commented Oct 29, 2013

ppurka commented Oct 29, 2013

ppurka commented Oct 29, 2013

jdemeyer commented Oct 31, 2013