Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symbolic vectors to be simplified elementwise #11335

Closed
jvkersch opened this issue May 16, 2011 · 8 comments
Closed

Allow symbolic vectors to be simplified elementwise #11335

jvkersch opened this issue May 16, 2011 · 8 comments

Comments

@jvkersch
Copy link

This patch adds a class Vector_symbolic_dense to sage.modules, whose functionality at this stage consists solely of providing a simplify_full method. The need for such functionality came up in the review of #10132 (metric surfaces in 3D), where symbolic vectors with complicated entries show up, and explicitly calling simplify_full all the time would be cumbersome (see also #10552).

The modifications implemented by this patch are the following:

  • Adds the class Vector_symbolic_dense;
  • Adds functionality to the element_class function in sage.modules.free_module to use this class;
  • Changes some doctests in free_module_element.py (because vector([1, 2, pi]) is now a symbolic vector rather than an element of a generic free module).

Eventually, this class could be expanded along the lines of sage.matrix.matrix_symbolic_dense.

CC: @jasongrout @rbeezer @videlec

Component: symbolics

Keywords: vector, symbolic, simplify

Author: Joris Vankerschaver

Reviewer: Robert Bradshaw

Merged: sage-4.7.1.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11335

@robertwb
Copy link
Contributor

comment:2

Short and sweet. Looks good to me. More methods added at #11381.

@jvkersch
Copy link
Author

Reviewer: Robert Bradshaw

@jvkersch
Copy link
Author

comment:3

Hi Robert, thanks for the quick review!

@jdemeyer
Copy link

jdemeyer commented Jun 1, 2011

comment:4

The commit message of the patch should not be one very long line. Please wrap it into multiple lines but try to make sure that the first line makes sense by itself (this is what hg log shows).

@jvkersch
Copy link
Author

jvkersch commented Jun 1, 2011

symbolic vector class

@jvkersch
Copy link
Author

jvkersch commented Jun 1, 2011

comment:5

Attachment: sage-symb-vectors.patch.gz

Hi Jeroen, thanks for the notification. I've updated the patch accordingly.

@jdemeyer
Copy link

jdemeyer commented Jun 7, 2011

comment:7

Joris, in the future it would be better to have the ticket number in the filename, for two reasons:

  1. it improves greppability.
  2. it ensures that no two patches from different tickets have the same filename.

@jdemeyer
Copy link

jdemeyer commented Jun 8, 2011

Merged: sage-4.7.1.alpha3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants