New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow symbolic vectors to be simplified elementwise #11335
Comments
comment:2
Short and sweet. Looks good to me. More methods added at #11381. |
Reviewer: Robert Bradshaw |
comment:3
Hi Robert, thanks for the quick review! |
comment:4
The commit message of the patch should not be one very long line. Please wrap it into multiple lines but try to make sure that the first line makes sense by itself (this is what |
symbolic vector class |
comment:5
Attachment: sage-symb-vectors.patch.gz Hi Jeroen, thanks for the notification. I've updated the patch accordingly. |
comment:7
Joris, in the future it would be better to have the ticket number in the filename, for two reasons:
|
Merged: sage-4.7.1.alpha3 |
This patch adds a class
Vector_symbolic_dense
tosage.modules
, whose functionality at this stage consists solely of providing asimplify_full
method. The need for such functionality came up in the review of #10132 (metric surfaces in 3D), where symbolic vectors with complicated entries show up, and explicitly callingsimplify_full
all the time would be cumbersome (see also #10552).The modifications implemented by this patch are the following:
Vector_symbolic_dense
;element_class
function insage.modules.free_module
to use this class;free_module_element.py
(becausevector([1, 2, pi])
is now a symbolic vector rather than an element of a generic free module).Eventually, this class could be expanded along the lines of
sage.matrix.matrix_symbolic_dense
.CC: @jasongrout @rbeezer @videlec
Component: symbolics
Keywords: vector, symbolic, simplify
Author: Joris Vankerschaver
Reviewer: Robert Bradshaw
Merged: sage-4.7.1.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/11335
The text was updated successfully, but these errors were encountered: