New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some other embeddings for graph generators #11399
Comments
Attachment: trac_11399.patch.gz |
This comment has been minimized.
This comment has been minimized.
comment:2
Nicer still. Builds, applies, and performs nicely on 4.7. I'm going to run tests, since it seems the patchbot has not done its thing yet, and then will flip this to positive review. Do we now have all the Platonic solids embedded properly? Rob |
Reviewer: Rob Beezer |
comment:4
Hem... We are missing the .... cube :-D I just wrote the embedding, but I wondered : is it better to append it to this patch, or to create another one ? Writing the cube's embedding is so much less interesting than the dodecahedron's Nathann |
comment:5
Replying to @nathanncohen:
Either way, I guess. If I don't get to it today, it might sit until Sage Days (which perhaps argues for another ticket?). |
comment:6
Attachment: trac_11399-cube.patch.gz It was indeed a stupid question Nathann |
This comment has been minimized.
This comment has been minimized.
comment:8
Got it. Cube looks good as well. Passes long tests, applies to 4,7, etc, etc. Thanks for filling in these details, or perhaps I should say, "Thank-yoooouuuu!!!!!!!!!!!!!!!" |
Merged: sage-4.7.1.alpha3 |
I wrote #11397 because I needed it, but as some other embeddings really looked alike, it would have been stupid not to fix them too
:-)
Apply:
Nathann
CC: @rbeezer
Component: graph theory
Author: Nathann Cohen
Reviewer: Rob Beezer
Merged: sage-4.7.1.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/11399
The text was updated successfully, but these errors were encountered: