Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZigZag and rational (canonical) forms #11480

Closed
rbeezer mannequin opened this issue Jun 14, 2011 · 10 comments
Closed

ZigZag and rational (canonical) forms #11480

rbeezer mannequin opened this issue Jun 14, 2011 · 10 comments
Assignees
@jasongrout @williamstein
Labels
c: linear algebra p: major / 3 t: enhancement
Milestone
sage-4.7.2

Comments

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jun 14, 2011

For matrices, ZigZag form is a precursor for a computation of the rational canonical form (and interesting in its own right). Then we get rational form also, a canonical form computable over any field, which will make is_similar() bullet-proof.

Apply:

  1. attachment: trac_11480_zigzag_rational_forms.patch

Depends:

  1. Companion matrix constructor #11356

Depends on #11356

CC: @dandrake

Component: linear algebra

Keywords: sd31

Author: Rob Beezer

Reviewer: David Loeffler

Merged: sage-4.7.2.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/11480
@rbeezer rbeezer mannequin added this to the sage-4.7.1 milestone Jun 14, 2011
@rbeezer rbeezer mannequin assigned jasongrout and williamstein Jun 14, 2011
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jun 14, 2011

Attachment: trac_11480_zigzag_rational_forms.patch.gz

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jun 14, 2011

Author: Rob Beezer

@rbeezer

This comment has been minimized.

Sign in to view
@rbeezer rbeezer mannequin added the s: needs review label Jun 14, 2011
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jun 14, 2011

Changed keywords from none to sd31

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jun 14, 2011

Dependencies: #11356

@rbeezer

This comment has been minimized.

Sign in to view
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 21, 2011

comment:3

Great stuff! Code looks really sound, all doctests pass, and I tried a bunch of random corner cases and it coped with all of them gracefully. Positive review.

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 21, 2011

Reviewer: David Loeffler

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jul 21, 2011

comment:4

Replying to @loefflerd:

Great stuff!

Hi David,

Yes, this was a fun one. And I plan to stitch it into .is_similar() to make that bullet-proof.

I was secretly hoping you were headed to this one after taking care of the companion matrix constructor. Thanks very much for looking it over and carefully putting it through its paces.

Rob

@jdemeyer jdemeyer modified the milestones: sage-4.7.1, sage-4.7.2 Jul 22, 2011
@jdemeyer
Copy link

Merged: sage-4.7.2.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@williamstein williamstein

Labels
c: linear algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.7.2
Development

No branches or pull requests
3 participants
@jasongrout @williamstein @jdemeyer