Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DB_HOME in preference of SAGE_DATA #11640

Closed
ohanar opened this issue Aug 1, 2011 · 7 comments
Closed

Remove DB_HOME in preference of SAGE_DATA #11640

ohanar opened this issue Aug 1, 2011 · 7 comments
Assignees
@jasongrout
Labels
p: major / 3 t: enhancement
Milestone
sage-4.7.2

Comments

@ohanar
Copy link
Member

ohanar commented Aug 1, 2011

Currently DB_HOME is defined in various files throughout Sage, and in all but one case they point to SAGE_DATA. I've attached a patch to remove these in preference of the, in my opinion, more standard SAGE_DATA.

Apply attachment: trac_11640.patch to the Sage library.

CC: @JohnCremona @williamstein

Component: misc

Keywords: SAGE_DATA, DB_HOME

Author: R. Andrew Ohana

Reviewer: Tom Boothby

Merged: sage-4.7.2.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11640
@ohanar ohanar added this to the sage-4.7.2 milestone Aug 1, 2011
@ohanar
Copy link
Member Author

ohanar commented Aug 2, 2011

Attachment: trac_11640.patch.gz

@boothby
Copy link

boothby commented Aug 25, 2011

comment:2

looks good, works good.

@boothby
Copy link

boothby commented Aug 25, 2011

Reviewer: Tom Boothby

@boothby
Copy link

boothby commented Aug 25, 2011

Author: Andrew Ohana

@nexttime

This comment has been minimized.

Sign in to view
@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 8, 2011

Changed author from Andrew Ohana to R. Andrew Ohana

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 12, 2011

Merged: sage-4.7.2.alpha3

@nexttime nexttime mannequin removed the s: positive review label Sep 12, 2011
@nexttime nexttime mannequin closed this as completed Sep 12, 2011
@williamstein williamstein mentioned this issue Dec 18, 2011
Closed
@ohanar ohanar mentioned this issue Apr 22, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

Labels
p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.7.2
Development

No branches or pull requests
3 participants
@jasongrout @boothby @ohanar