Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_monomial() to power series and laurent series ring elements #11719

Closed
boothby opened this issue Aug 23, 2011 · 16 comments
Closed

Add is_monomial() to power series and laurent series ring elements #11719

boothby opened this issue Aug 23, 2011 · 16 comments

Comments

@boothby
Copy link

boothby commented Aug 23, 2011

It should be trivial to check if a power/laurent series ring element is a monomial or not. It is not.

Component: commutative algebra

Keywords: sd32, laurent series, power series

Author: Tom Boothby, Ralf Stephan

Branch/Commit: c3851c0

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/11719

@boothby

This comment has been minimized.

@boothby

This comment has been minimized.

@boothby boothby changed the title Add is_monomial() to power series ring elements Add is_monomial() to power series and laurent series ring elements Aug 23, 2011
@boothby
Copy link
Author

boothby commented Aug 25, 2011

Changed keywords from none to sd32

@boothby
Copy link
Author

boothby commented Aug 25, 2011

comment:5

Attachment: trac_11719.patch.gz

@boothby
Copy link
Author

boothby commented Aug 25, 2011

Author: Tom Boothby

@boothby
Copy link
Author

boothby commented Aug 25, 2011

Dependencies: #11726

@williamstein
Copy link
Contributor

comment:8

Needs work, due to #11747 -- ambiguity of is_monomial.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@fchapoton
Copy link
Contributor

Changed keywords from sd32 to sd32, laurent series, power series

@rwst
Copy link

rwst commented Apr 22, 2014

@rwst
Copy link

rwst commented Apr 22, 2014

Commit: c3851c0

@rwst
Copy link

rwst commented Apr 22, 2014

comment:13

Rebased on 6.2.beta8. I changed the implementation of LaurentPolynomial.is_monomial because it gave the wrong (in the sense of #11747) result. It would also have marked zero as a monomial which would be wrong IMHO, and not according to Polynomial.is_monomial. I also changed the documentation to fit #11747. I removed the words non-negative from the doc of the laurent_polynomial.pyx implementation. I finally fixed appearances of "Returns".


New commits:

c3851c011719: add is_monomial to power series and Laurent poly and series

@rwst
Copy link

rwst commented Apr 22, 2014

Changed author from Tom Boothby to Tom Boothby, Ralf Stephan

@rwst
Copy link

rwst commented Apr 22, 2014

Changed dependencies from #11726 to none

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@pjbruin
Copy link
Contributor

pjbruin commented May 11, 2014

Reviewer: Peter Bruin

@pjbruin
Copy link
Contributor

pjbruin commented May 11, 2014

comment:15

Looks good and the patchbot is happy.

@vbraun
Copy link
Member

vbraun commented May 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants