Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library gmp needed for real interval absolute #11744

Closed
kcrisman opened this issue Aug 25, 2011 · 10 comments
Closed

Add library gmp needed for real interval absolute #11744

kcrisman opened this issue Aug 25, 2011 · 10 comments

Comments

@kcrisman
Copy link
Member

Cygwin fails on the new file introduced in #9180. We need

libraries = ['gmp']

in that extension in module_list.py for this to build properly.


Apply attachment: trac_11744.patch to the Sage library.

CC: @robertwb

Component: porting: Cygwin

Author: Karl-Dieter Crisman

Reviewer: Mike Hansen

Merged: sage-4.7.2.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11744

@kcrisman
Copy link
Member Author

comment:1

See #11499 for type of patch needed.

@kcrisman
Copy link
Member Author

Attachment: trac_11744.patch.gz

@kcrisman
Copy link
Member Author

Author: Karl-Dieter Crisman

@kcrisman
Copy link
Member Author

comment:2

Ready for review! I guess we COULD wait until someone actually tests this on Cygwin, or perhaps the author of #9180 could confirm that gmpz things need to be defined for said pyx file to compile properly. Anyway, ready for review :)

@mwhansen
Copy link
Contributor

comment:3

From the code at #9180, it's clear that it requires GMP. Looks good to me.

@mwhansen
Copy link
Contributor

Reviewer: Mike Hansen

@robertwb
Copy link
Contributor

comment:4

Thanks for taking care of this oversight.

@kcrisman
Copy link
Member Author

comment:5

Replying to @robertwb:

Thanks for taking care of this oversight.

My pleasure - it was nice to find something I could actually fix for once! Thanks to Mike having shown me the way at Days 31 on a similar ticket.


You can make it up by reviewing #11119, which should be very easy to finish off :) Or even by checking that the links in #11245 are hard (should be enough to finish the review), and/or checking the spkg construction in #11497, etc. It would be so nice to just be able to type "make" and only have to fix the build at Maxima. Then we just have to figure out #11551 and #9167... not to mention that now my Win 7 computer fails at importing sage.misc.random, before it even gets to initializing I, which is new to me...

@nexttime

This comment has been minimized.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 12, 2011

Merged: sage-4.7.2.alpha3

@nexttime nexttime mannequin removed the s: positive review label Sep 12, 2011
@nexttime nexttime mannequin closed this as completed Sep 12, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants