Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the developer's guide #11816

Closed
saraedum opened this issue Sep 19, 2011 · 9 comments
Closed

Typo in the developer's guide #11816

saraedum opened this issue Sep 19, 2011 · 9 comments

Comments

@saraedum
Copy link
Member

Should one really open a ticket for something like this?

where <repo-name> is the name of the repository you are using, and <format is “html”, “pdf”, [...]

Apply only attachment: trac_11816_typo.proper.patch to the Sage library.

Component: documentation

Author: Julian Rueth

Reviewer: Leif Leonhardy

Merged: sage-4.7.2.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11816

@saraedum
Copy link
Member Author

fixes a typo in the developer's guide

@saraedum
Copy link
Member Author

comment:1

Attachment: trac_11816_typo.patch.gz

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 19, 2011

Replying to @saraedum:

Should one really open a ticket for something like this?

In principle yes, since otherwise they're likely to stay forever.

In this case, I'm pretty sure I've already corrected it in a not-yet-published version (a reviewer patch I have to provide for another ticket), but haven't found the time to finish it.

Once you start looking for typos, wrong formatting and inconsistencies (or meanwhile obsolete information), you're likely to not get to an end, unfortunately... ;-)

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 19, 2011

Reviewer: Leif Leonhardy

@nexttime

This comment has been minimized.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 20, 2011

Merged: sage-4.7.2.alpha3

@nexttime nexttime mannequin removed the s: positive review label Sep 20, 2011
@nexttime nexttime mannequin closed this as completed Sep 20, 2011
@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 28, 2011

Attachment: trac_11816_typo.proper.patch.gz

"Proper" Mercurial changeset replacement patch.

@nexttime

This comment has been minimized.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 28, 2011

comment:5

I've attached a *.proper.patch, which is identical except that I removed the "garbage" before "# HG changeset patch", i.e., I deleted the first line "exporting patch:", since Jeroen's current merger rejects such patches.

For now, please make sure all your patches start with "# HG changeset patch", i.e., have it on the first line without any preceding messages or whatever.

I've relaxed that in my version of the merger, but Jeroen and maybe others are likely to use his more restrictive one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant