New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a bug in is_chordal -- two algorithms #11961
Comments
This comment has been minimized.
This comment has been minimized.
Milestone sage-4.7.3 deleted |
Attachment: trac_11961.patch.gz |
comment:3
I had no problem when installing the patch. The doc is also correctly generated. All tests I have performed are consistent: both algorithms return the same boolean value. The certificate are not the same when several certificates are possible. Algorithm B is a bit slower than algorithm A. As I already said for patch #11735, significant running time improvements are possible for these linear time algorithms, but at least we have some algorithms ;) Thank you Nathann. |
Reviewer: David Coudert |
comment:4
Thank you for the review !
Yep. That's why it is good to have both
These codes are really standard. It would really be a shame not to implement them properly in C/C++ at some point. Nathann |
Merged: sage-4.8.alpha5 |
This ticket follows #11735, which fixes the bug reported by Jan on sage-devel [1]. It makes his alternative algorithm available in the function, so that we now have two different versions available, and still double-check the values it returns
:-)
Requires : #11735
Apply : attachment: trac_11961.patch
[1] https://groups.google.com/d/topic/sage-support/rU1VTz1Ou_I/discussion
Component: graph theory
Author: Nathann Cohen, Jan Elffers
Reviewer: David Coudert
Merged: sage-4.8.alpha5
Issue created by migration from https://trac.sagemath.org/ticket/11961
The text was updated successfully, but these errors were encountered: