New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numerical_approx broken for vectors #12195
Comments
Attachment: 12195-numerical_approx.patch.gz |
This comment has been minimized.
This comment has been minimized.
comment:3
Robert, Looks good, and very welcome. I should have noticed, and fixed, this omission during my big push last year. Looks ready for a positive review, but I have two questions.
A suggestion - add a doctest in this patch for the generic method exhibiting application to vectors. If that's agreeable, I'll make a ticket to have matrices follow the model of this ticket (and maybe even do it). Rob |
Changed keywords from none to sd40.5 |
Author: robertwb |
Reviewer: Rob Beezer, William Stein |
comment:5
This clearly needs work. Rob's point about there being an n method right before is serious. That should be deleted, and was the result of somebody not understanding the architecture of N... |
I fixed the patch by deleting the n function before. Looks great! |
comment:6
Attachment: 12195-numerical_approx.2.patch.gz apply only: 12195-numerical_approx.2.patch |
Attachment: trac_12195-numerical-approx-v3.patch.gz |
Changed author from robertwb to Robert Bradshaw, Rob Beezer, William Stein |
This comment has been minimized.
This comment has been minimized.
comment:7
|
comment:9
Hello patchbot, please apply trac_12195-numerical-approx-v3.patch Thank you |
Changed reviewer from Rob Beezer, William Stein to Rob Beezer, William Stein, Dan Drake |
Merged: sage-5.1.beta4 |
#1294 implemented
n()
but notN()
or the functionalnumerical_approx
Apply:
CC: @rbeezer @jasongrout
Component: linear algebra
Keywords: sd40.5
Author: Robert Bradshaw, Rob Beezer, William Stein
Reviewer: Rob Beezer, William Stein, Dan Drake
Merged: sage-5.1.beta4
Issue created by migration from https://trac.sagemath.org/ticket/12195
The text was updated successfully, but these errors were encountered: