New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eulerian circuits/paths for (di)graphs #12325
Comments
Attachment: trac_12325_eulerian_paths.patch.gz |
comment:2
Hellooooooooooooooooo !!! Looks good ! Some comments :
Nathann |
Attachment: trac_12325_eulerian_move.patch.gz |
Attachment: trac_12325_eulerian_paths.2.patch.gz |
comment:3
Hi, thanks for the remarks very much. I tried to rewrite the fix -- you are certainly right that the eulerianess-checking code should be in the is_eulerian function. I am a big fan of "the lazy way" :-), but in this case it makes almost no difference, because there are no changes in the algorithm needed for allowing the path computation -- the only important step is setting the start_vertex variable. And thanks for the advice about two patches -- it definitelly makes sense. Lukáš. |
comment:4
Hellooooooooooooo !!! Great ! Thank you very much for these two patches, it is much easier to read. And you also factored things like many (g.degree(u)-g.degree(v)) Well, I see nothing wrong with this patch, it passes all tests and does it job. Could you rebase the first of your two patches over sage-4.5-beta1 though ? It still does not apply. Nathann |
This comment has been minimized.
This comment has been minimized.
comment:5
Argggggg !! It's totally my fault ! I had not seen the patch depended on #10135. There's nothing left to do with this patch Nathann |
Reviewer: Nathann Cohen |
comment:6
This one is also good to go, and now its dependency has been reviewed ! Nathann |
Author: Lukáš Lánský |
comment:7
Thank you for the review. :-) |
Merged: sage-5.0.beta3 |
Currently, there is only a function for finding an eulerian circuit in an undirected graph.
Apply :
Depends on #10135
CC: @sagetrac-brunellus
Component: graph theory
Author: Lukáš Lánský
Reviewer: Nathann Cohen
Merged: sage-5.0.beta3
Issue created by migration from https://trac.sagemath.org/ticket/12325
The text was updated successfully, but these errors were encountered: