Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph.relabel modifies the dictionary given as an input #12477

Closed
nathanncohen mannequin opened this issue Feb 8, 2012 · 7 comments
Closed

Graph.relabel modifies the dictionary given as an input #12477

nathanncohen mannequin opened this issue Feb 8, 2012 · 7 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Feb 8, 2012

Well, it's as the title says...

The patch just fixes it in the obvious way, and moves some code around to make it easier to read.

(reported by Nicolas Thiéry)

sage: g = Graph({1:[2,3]})
sage: rel = {1:'a', 2:'b'}
sage: g.relabel(rel)
sage: g.vertices()
[3, 'a', 'b']
sage: rel
{1: 'a', 2: 'b', 3: 3}

Nathann

CC: @nthiery

Component: graph theory

Keywords: Cernay2012

Author: Nathann Cohen

Reviewer: Nicolas M. Thiéry

Merged: sage-5.0.beta5

Issue created by migration from https://trac.sagemath.org/ticket/12477

@nathanncohen nathanncohen mannequin added this to the sage-5.0 milestone Feb 8, 2012
@nathanncohen

This comment has been minimized.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 8, 2012

Changed keywords from none to Cernay2012

@nathanncohen nathanncohen mannequin added the s: needs review label Feb 8, 2012
@nthiery
Copy link
Contributor

nthiery commented Feb 8, 2012

Reviewer: Nicolas M. Thiéry

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Feb 8, 2012

comment:2

Attachment: trac_12477.patch.gz

@nthiery
Copy link
Contributor

nthiery commented Feb 8, 2012

comment:3

Discussed together. The tests on the file pass. Positive review assuming the buildbot gives a green light.

Thanks Nathann!

@jdemeyer
Copy link

Merged: sage-5.0.beta5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants