New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix four SPKGs with irregular directory structures #12694
Comments
This comment has been minimized.
This comment has been minimized.
Dependencies: #12644 |
comment:3
I have uploaded an spkg. |
comment:4
The above comment was a test of the newly upgraded trac server. Here are two more SPKGs. |
This comment has been minimized.
This comment has been minimized.
comment:5
And the last one. |
This comment has been minimized.
This comment has been minimized.
Author: Keshav Kini |
comment:6
these are not the comments you are looking for |
comment:7
CCing the maintainers of the SPKGs |
comment:8
the elliptic_curves spkg still has the ellcurves directory (which should now be gone), also at the same time you may as well remove the xreadlines from the spkg-install since the command has be deprecated (in favor of just using an implicit iterator) |
Reviewer: R. Andrew Ohana |
comment:9
Oops, how did that happen... fixed (I think). |
comment:10
|
comment:11
You caught me - that's already fixed, download it again :) |
comment:12
I also would remove Emily as the maintainer of the graphs spkg, she hasn't been around for years (if I had the source for her db file, I would maintain this package, but alas, I don't, maybe Jason or William does?). |
comment:13
Jason? William? |
comment:14
also, in the polytopes_db I would suggest changing the cp to a mv (like you did with the graphs spkg), removes nearly all io assuming you are building and installing on the same disk |
comment:15
Is the graphs spkg my 8-vertex graph properties database? It's a sqlite database, right? Probably the easiest thing to do is to dump the sql to a text file and put that in src/. We could even just distribute that and build the sqlite database on the fly when the spkg is installed. |
comment:16
Replying to @jasongrout:
I would suggest this, it should reduce the size of the spkg, which is always a good thing, and it shouldn't take long to build. Plus, I did a major refactoring of the SQLDatabase object in Sage last summer, and had to put some special cases in for the Graph's database (that could be fixed with this). In any case, I think this belongs in a separate ticket. For now, mark me as the maintainer of the graphs spkg. |
comment:17
Done and done. |
comment:18
ok, looks good now |
Changed keywords from libm4ri elliptic_curves graphs polytopes_db to libm4ri elliptic_curves graphs polytopes_db rd2 |
comment:19
Thanks! |
Merged: sage-5.0.beta10 |
The following SPKGs do not have a
src/
directory:The sage spkgs are obviously supposed to be irregular (I guess) but the other four -
libm4ri
,elliptic_curves
,graphs
, andpolytopes_db
should follow the guidelines given in the developers' guide and have asrc/
directory.Install:
Depends on #12644
CC: @ohanar @malb @sagetrac-ekirkman @novoselt @jasongrout @williamstein
Component: packages: standard
Keywords: libm4ri elliptic_curves graphs polytopes_db rd2
Author: Keshav Kini
Reviewer: R. Andrew Ohana
Merged: sage-5.0.beta10
Issue created by migration from https://trac.sagemath.org/ticket/12694
The text was updated successfully, but these errors were encountered: