Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R spkg: use -### instead of -v to detect linker options #12787

Closed
jdemeyer opened this issue Mar 30, 2012 · 19 comments
Closed

R spkg: use -### instead of -v to detect linker options #12787

jdemeyer opened this issue Mar 30, 2012 · 19 comments

Comments

@jdemeyer
Copy link

Reported upstream (R): https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=14865 -- bug was determined to be caused by autoconf

Reported grandupstream (autoconf): http://lists.gnu.org/archive/html/bug-autoconf/2012-06/msg00000.html with patch sent to http://lists.gnu.org/archive/html/autoconf-patches/2012-07/msg00007.html -- no feedback at all

Also do some clean-up of the R spkg.

spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/r-2.14.0.p3.spkg

Upstream: None of the above - read trac for reasoning.

CC: @nexttime

Component: packages: standard

Author: Jeroen Demeyer

Reviewer: Volker Braun

Merged: sage-5.1.beta0

Issue created by migration from https://trac.sagemath.org/ticket/12787

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Upstream: Reported upstream. Little or no feedback.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Mar 30, 2012

Author: Jeroen Demeyer

@nexttime
Copy link
Mannequin

nexttime mannequin commented Mar 30, 2012

Replying to @jdemeyer:

Also do some clean-up of the R spkg.

I already cleaned up SPKG.txt, spkg-install and spkg-check at #9906; this just complicates rebasing, again, as you also made some of the changes I made there, but not all of them.

FWIW, #9906, which really wasn't that hard to review, as I intentionally did not upgrade R or RPy there, rottens anyway...

@jdemeyer
Copy link
Author

comment:7

Replying to @nexttime:

Replying to @jdemeyer:

Also do some clean-up of the R spkg.

I already cleaned up SPKG.txt, spkg-install and spkg-check at #9906; this just complicates rebasing, again, as you also made some of the changes I made there, but not all of them.

It shouldn't be that much work to rebase, spkg-install and spkg-check aren't that big...

@jdemeyer
Copy link
Author

comment:8

Anyway, this spkg does fix the problem I was having, so needs review.

@jdemeyer
Copy link
Author

Diff for the R spkg, for review only

@vbraun
Copy link
Member

vbraun commented May 2, 2012

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented May 2, 2012

comment:9

Attachment: r-2.14.0.p3.diff.gz

Looks good.

I guess #9906 won't be finished in time for sage-5.0, so lets go with this.

@jdemeyer
Copy link
Author

jdemeyer commented May 2, 2012

comment:10

Actually, this isn't meant for sage-5.0.

@jdemeyer jdemeyer modified the milestones: sage-5.0, sage-5.1 May 2, 2012
@jdemeyer
Copy link
Author

jdemeyer commented May 6, 2012

Merged: sage-5.1.beta0

@jdemeyer
Copy link
Author

jdemeyer commented May 6, 2012

comment:11

Too bad upstream is totally ignoring this...

@jdemeyer
Copy link
Author

Changed upstream from Reported upstream. Little or no feedback. to None of the above - read trac for reasoning.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

comment:14

Grandupstream (autoconf) is completely ignoring my bug request and patch.

@jdemeyer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants