Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building polybori under FreeBSD #12818

Closed
sagetrac-stephen mannequin opened this issue Apr 8, 2012 · 18 comments
Closed

Building polybori under FreeBSD #12818

sagetrac-stephen mannequin opened this issue Apr 8, 2012 · 18 comments

Comments

@sagetrac-stephen
Copy link
Mannequin

sagetrac-stephen mannequin commented Apr 8, 2012

I need this patch to build under FreeBSD:

--- src/polybori-0.8.0/Cudd/cudd/cudd.h-orig 2012-02-09 03:18:02.000000000 +0000
+++ src/polybori-0.8.0/Cudd/cudd/cudd.h 2012-02-09 03:19:20.000000000 +0000
@@ -82,6 +82,12 @@
 
 #endif
 
+#ifdef __cplusplus
+#include <cstdio>
+#else
+#include <stdio.h>
+#endif
+
 #ifdef __cplusplus
 extern "C" {
 #endif

This patch should be harmless to all builds under other OS.


Duplicate of #13124.

Depends on #13124

Upstream: Fixed upstream, in a later stable release.

CC: @alexanderdreyer

Component: porting: BSD

Keywords: FreeBSD polybori

Reviewer: Stephen Montgomery-Smith, Alexander Dreyer, Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/12818

@sagetrac-stephen sagetrac-stephen mannequin added this to the sage-5.1 milestone Apr 8, 2012
@sagetrac-stephen sagetrac-stephen mannequin added the p: major / 3 label Apr 8, 2012
@sagetrac-stephen
Copy link
Mannequin Author

sagetrac-stephen mannequin commented Apr 8, 2012

patch for cudd.h

@sagetrac-stephen
Copy link
Mannequin Author

sagetrac-stephen mannequin commented Apr 8, 2012

Attachment: Cudd.cudd.cudd.h.gz

patch for spkg-install

@sagetrac-stephen
Copy link
Mannequin Author

sagetrac-stephen mannequin commented Apr 11, 2012

comment:1

Attachment: spkg-patch-polybori-0.8.0.p2_-_spkg_install.gz

@alexanderdreyer
Copy link
Mannequin

alexanderdreyer mannequin commented Jun 15, 2012

Upstream: Fixed upstream, in a later stable release.

@alexanderdreyer
Copy link
Mannequin

alexanderdreyer mannequin commented Jun 15, 2012

comment:2

Thanks, the patch will be part of polybori-0.8.2, see https://bitbucket.org/brickenstein/polybori/changeset/8aed782d9baf .

@kcrisman
Copy link
Member

Author: Stephen Montgomery-Smith

@kcrisman
Copy link
Member

comment:3

Is there an ETA on when that will be in Sage, or should we try to make an spkg update?

@kcrisman
Copy link
Member

Reviewer: Alexander Dreyer

@alexanderdreyer
Copy link
Mannequin

alexanderdreyer mannequin commented Jun 20, 2012

comment:4

Meanwhile the new spkg is at #13124. Feel free to try it out. If it solves you problem, this one may be considered as a duplicate of #13124.

@kcrisman
Copy link
Member

Changed reviewer from Alexander Dreyer to Alexander Dreyer, Karl-Dieter Crisman

@kcrisman
Copy link
Member

comment:5

I can confirm that the patch in question is included in #13124. Since this is definitely the only thing from the FreeBSD port list from polybori, I think that we can close this ticket.

@kcrisman
Copy link
Member

Dependencies: #13124

@sagetrac-stephen
Copy link
Mannequin Author

sagetrac-stephen mannequin commented Jun 21, 2012

comment:8

I can confirm that ticket #13124 fixes this problem for FreeBSD.

@alexanderdreyer
Copy link
Mannequin

alexanderdreyer mannequin commented Jun 25, 2012

comment:9

Duplicate of #13124.

@alexanderdreyer

This comment has been minimized.

@alexanderdreyer alexanderdreyer mannequin removed this from the sage-5.2 milestone Jun 25, 2012
@jdemeyer
Copy link

jdemeyer commented Jul 8, 2012

Changed reviewer from Alexander Dreyer, Karl-Dieter Crisman to Stephen Montgomery-Smith, Alexander Dreyer, Karl-Dieter Crisman

@jdemeyer
Copy link

jdemeyer commented Jul 8, 2012

Changed author from Stephen Montgomery-Smith to none

@fchapoton

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants