Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critical bug in multivariate polynomial factorization over GF(2) #12928

Closed
zimmermann6 opened this issue May 9, 2012 · 10 comments
Closed

critical bug in multivariate polynomial factorization over GF(2) #12928

zimmermann6 opened this issue May 9, 2012 · 10 comments

Comments

@zimmermann6
Copy link

consider the following (both with Sage 4.8 and Sage 5.0.beta13 without proof=False):

sage: R.<x,y>=GF(2)[]
sage: factor(x^6 + y^6 + x^5 + x^3 + x + 1,proof=False)
x^6 + y^6 + x^5 + x^3 + x + 1
sage: (x^4+y^2*x^2+x^2+y^2*x+y^4+y^2+1)*(x^2+x+y^2+1)     
x^6 + y^6 + x^5 + x^3 + x + 1

This seems to be a bug in Singular factorization. I set the priority to "critical" since this is really a very basic routine.

Paul

Upstream: Fixed upstream, in a later stable release.

CC: @malb

Component: factorization

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/12928

@zimmermann6
Copy link
Author

comment:2

here is another example:

sage: R.<x,t> = GF(2)[]
sage: f=x^6 + (t^5 + t^2)*x + t^5 + t^4 + t^3 + 1
sage: factor(f,proof=False)                      
x^6 + x*t^5 + t^5 + t^4 + x*t^2 + t^3 + 1
sage: f % (x+t+1)
0

Note that the factorization algorithm seems not to be deterministic, thus some times the
factorization is correct.

Paul

@zimmermann6
Copy link
Author

comment:3

Note that for the example given in the description, the "bug" seems to be deterministic.

Paul

@malb
Copy link
Member

malb commented May 10, 2012

comment:4

Hi, can you guys report this upstream? I am travelling this week.

@zimmermann6
Copy link
Author

Upstream: Reported upstream. Little or no feedback.

@zimmermann6
Copy link
Author

comment:5

reported upstream, see http://www.singular.uni-kl.de:8002/trac/ticket/424

@zimmermann6
Copy link
Author

comment:6

the bug is fixed upstream. I have asked in which release the patch will be.

Paul

@zimmermann6
Copy link
Author

Changed upstream from Reported upstream. Little or no feedback. to Fixed upstream, in a later stable release.

@zimmermann6
Copy link
Author

comment:7

upstream says it is fixed in 3-1-4-4.

Paul

@jdemeyer
Copy link

jdemeyer commented Aug 3, 2012

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

jdemeyer commented Aug 3, 2012

comment:8

Fixed by #13237.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants