-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Singular #13237
Comments
Changed keywords from none to spkg |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author: Jeroen Demeyer |
This comment has been minimized.
This comment has been minimized.
Changed keywords from spkg to Singular spkg |
This comment has been minimized.
This comment has been minimized.
comment:6
:P And lots of other warnings... |
comment:7
Replying to @nexttime:
These are the ones I get from
The unrecognized options should be addressed I think. No idea how to interpret " "Building without python support" can safely be ignored I guess, as we use our own Cython wrappers. |
comment:8
Replying to @nexttime:
I fixed the fixable warnings. Many of them are caused by recursive calling of |
This comment has been minimized.
This comment has been minimized.
comment:10
I assume that this is work in progress (i.e., you haven't tried to fix doctest errors yet). Anyway, here's what I got on Ubuntu 10.04.4 LTS x86_64, with Sage 5.2.rc0 and GCC 4.7.0:
(The last failure was a segfault with a large traceback IIRC. Somewhat surprisingly successfully compiled with Let me know in case you're interested in further output; I guess you can reproduce most of the errors. |
comment:11
Replying to @nexttime:
Exactly, I mainly worked on |
comment:12
This is a new bug, the new answer is incorrect:
|
comment:13
Replying to @jdemeyer:
Yes, the most obvious one... :-) Just noticed the failure in
|
This comment has been minimized.
This comment has been minimized.
comment:15
Another Singular bug:
Reported upstream at http://www.singular.uni-kl.de:8002/trac/ticket/440. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Upstream: None of the above - read trac for reasoning. |
comment:17
New spkg, adds fixes for Singular bugs 439 and 440. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:20
Reproducible doctest failure:
Non-reproducible doctest failure:
|
comment:21
So far I only tested the files that previously failed for me (with the new spkg and the Sage library patch applied). I get the same
(For me it's line 3910; presumably due to some other patch. The first variant seems to occur more often. All tests run sequentially, FWIW.) P.S.: Run 100 times from the shell, the test failed 51 times. |
comment:73
Replying to @jdemeyer:
Indeed, I can confirm that the tests check for recurrence of the solved problems. |
comment:74
There is a small thing that I'd like to change: There is a header table.h, that is currently not installed. However, it is needed by libsing (not libsingular). libsing is a package allowing GAP to use Singular natively. I don't know if it would be of general interest to have it in Sage. Anyway: Should there be a new ticket for the installation of table.h, or should it be done here? |
comment:75
Replying to @simon-king-jena:
I think this is not related tot he upgrade, so this should be a feature request to the Singular-team. But of course, any resulting patch could be integrated in the next spkg eventually. |
comment:76
It seems to me that the spkg contains uncommitted changes. |
comment:77
Replying to @simon-king-jena:
You are very right, I forgot to do |
comment:78
Replying to @alexanderdreyer:
Granted. But if we upgrade Singular anyway, we could as well use a little patch that installs just one additional header.
Here is the suggested change, anyway. Add a file patches/install_table.patch containing
|
comment:79
I agree with AlexanderDreyer that you should make a request to upstream for |
comment:80
Replying to @jdemeyer:
I asked Hans Schönemann today, and he answered: "Meinetwegen." In English, I guess that's: "I don't mind." |
This comment has been minimized.
This comment has been minimized.
Attachment: singular-3-1-5.p1.diff.gz Diff for the singular spkg p0->p1. For reference / review only. |
comment:83
Replying to @jdemeyer: |
comment:84
One questions regarding Alexander's comment on #7797: Has it really been the case on Solaris SPARC that an outdated Singular/tok.h was hanging around? And if the answer is yes, a second question: Has the new singular spkg not properly installed the new one? |
comment:85
I am currently doing a complete build from scratch on Solaris SPARC with the new Singular to find out what's going on. |
comment:86
Replying to @jdemeyer:
What came out of it? |
comment:87
Replying to @simon-king-jena:
I'll answer at #7797 when it's finished compiling (which should be soon now) :-) |
Merged: sage-5.4.beta0 |
Upgrade Singular to version 3-1-5 (released 12 July 2012).
Upstream bugs discovered:
This new version fixes #13129, #12918, #12928, #12846, #12089, #13344.
Apply attachment: 13237_singular_3_1_5.patch and attachment: 13237_tests.patch to the Sage library.
New spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/singular-3-1-5.p1.spkg
singular-3-1-5.p1 (Simon King, 29 August 2012)
singular-3-1-5.p0 (Jeroen Demeyer, Alexander Dreyer, 10 August 2012)
patches in patches/*.patch, move conditional patches to
patches/conditional
and kernel.Makefile.in.debug.patch) into one file
conditional/sage_debug.patch.
make install-nolns. Instead, only do the latter.
part of the old distclean() into remove_old_version().
http://www.singular.uni-kl.de:8002/trac/ticket/438
Upstream: None of the above - read trac for reasoning.
CC: @kiwifb @malb @jpflori
Component: packages: standard
Keywords: Singular spkg
Author: Jeroen Demeyer, Alexander Dreyer, Dmitrii Pasechnik, Karl-Dieter Crisman, Jean-Pierre Flori
Reviewer: Alexander Dreyer, François Bissey
Merged: sage-5.4.beta0
Issue created by migration from https://trac.sagemath.org/ticket/13237
The text was updated successfully, but these errors were encountered: