Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Singular with FLINT support #13331

Closed
jpflori opened this issue Aug 3, 2012 · 29 comments
Closed

Build Singular with FLINT support #13331

jpflori opened this issue Aug 3, 2012 · 29 comments

Comments

@jpflori
Copy link

jpflori commented Aug 3, 2012

Once the updated FLINT 2 spkg at #12173 gets into Sage, Singular should be built with FLINT support.

Depends on #12173

CC: @burcin @jdemeyer

Component: packages: standard

Keywords: singular flint spkg

Author: Jean-Pierre Flori

Branch/Commit: 291e70b

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/13331

@jpflori jpflori added this to the sage-5.11 milestone Aug 3, 2012
@nexttime
Copy link
Mannequin

nexttime mannequin commented Aug 3, 2012

comment:1

Wonder whether Singular automatically uses FLINT if it finds the proper version (2.x?)...

Singular 3-1-5 (with our old FLINT 1.5.2) says

configure: WARNING: Unable to find FLINT (which is strongly recommended) on your machine: please use --with-flint=PATH_TO_DIR_CONTAINING_LIB_AND_INCLUDE (see also ./configure --help if you do not understand what we are talking about)

Does this ticket depend on #13237?

@jpflori
Copy link
Author

jpflori commented Aug 3, 2012

comment:2

Replying to @nexttime:

Does this ticket depend on #13237?

I guess it should.
It should even depend on the updated spkg I'll post in a few moments in #12089 based on the one in #13237.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Jun 13, 2013

comment:4

Just to make you aware of #14737 (new spkg presumably coming up soon).

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@jpflori
Copy link
Author

jpflori commented Feb 19, 2014

Author: Jean-Pierre Flori

@jpflori
Copy link
Author

jpflori commented Feb 19, 2014

Branch: u/jpflori/ticket/13331

@jpflori
Copy link
Author

jpflori commented Feb 19, 2014

comment:7

Modified the options passed to configured, cleaned up a little bit SPKG.txt and updated the deps file for pkgs.
Added a patch so that libsingular.so and not only Singular exe is actually linked to flint.
That should prevent future failure when I decide to test it under cygwin,I'll test it tonight.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2014

Commit: 3bf4cab

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

3bf4cabBuild Singular with FLINT support.

@kiwifb
Copy link
Member

kiwifb commented Mar 15, 2014

comment:9

Need a refresh since we are now at singular 3.1.6.p1. As the little configuration patch been forwarded upstream?

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@pjbruin
Copy link
Contributor

pjbruin commented May 7, 2014

Work Issues: does not merge with 6.2

@nexttime
Copy link
Mannequin

nexttime mannequin commented May 7, 2014

comment:12

Replying to @pjbruin:

  • Work issues set to does not merge with 6.2

Just because of #15937 or the changes to module_list.py etc.?

@nexttime
Copy link
Mannequin

nexttime mannequin commented May 7, 2014

comment:13

Oh, I see, it's also based on the old version of Singular, as François already mentioned.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 12, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

a54ff89Merge remote-tracking branch 'trac/develop' into ticket/13331

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 12, 2014

Changed commit from 3bf4cab to a54ff89

@jpflori
Copy link
Author

jpflori commented May 12, 2014

Changed work issues from does not merge with 6.2 to none

@jpflori
Copy link
Author

jpflori commented May 12, 2014

comment:15

I did not forward the little patch upstream for two reasons:

  • I'm not sure it will be needed by Singular 4-0-0 whose build system is completely different.
  • Singular issue tracker listens on an exotic port that I cannot access from the machine I developed the patch on.

@pjbruin
Copy link
Contributor

pjbruin commented May 16, 2014

comment:16

This seems all good except for two failing doctests where the output is a list whose ordering has changed:

sage -t --long src/doc/en/developer/coding_in_other.rst  # 1 doctest failed
sage -t --long src/doc/en/constructions/algebraic_geometry.rst  # 1 doctest failed

@pjbruin
Copy link
Contributor

pjbruin commented May 16, 2014

Reviewer: Peter Bruin

@nexttime
Copy link
Mannequin

nexttime mannequin commented May 17, 2014

comment:17

FTR/FYI:

There's a small patch at #12442 (attached, no branch) that lets Singular 3.1.6 build with clang.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2014

Changed commit from a54ff89 to ff841fe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

1c78c41Merge remote-tracking branch 'trac/develop' into ticket/13331
d45f16bLet Singular build with clang.
ff841feMerge branch 'ticket/12442' into ticket/13331

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2014

Changed commit from ff841fe to 9c02724

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

9c02724Force upgrade of Singular and fix doctests on 64 bits.

@jpflori
Copy link
Author

jpflori commented Jul 17, 2014

comment:20

Cannot test on 32 bits right now.
Is that a job for the patchbot?


New commits:

9c02724Force upgrade of Singular and fix doctests on 64 bits.

@pjbruin
Copy link
Contributor

pjbruin commented Jul 17, 2014

comment:21

Replying to @jpflori:

Cannot test on 32 bits right now.
Is that a job for the patchbot?

I don't know if anyone is running a 32-bit patchbot, but I will test it on ARM.

@pjbruin
Copy link
Contributor

pjbruin commented Jul 17, 2014

Changed commit from 9c02724 to 291e70b

@pjbruin
Copy link
Contributor

pjbruin commented Jul 17, 2014

Changed branch from u/jpflori/ticket/13331 to u/pbruin/13331-singular_flint

@pjbruin
Copy link
Contributor

pjbruin commented Jul 17, 2014

comment:22

Fixed 32-bit doctests, I think everything should work now.

@vbraun
Copy link
Member

vbraun commented Jul 19, 2014

Changed branch from u/pbruin/13331-singular_flint to 291e70b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants