Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage-location: handle lib64 also #13397

Closed
jdemeyer opened this issue Aug 24, 2012 · 8 comments
Closed

sage-location: handle lib64 also #13397

jdemeyer opened this issue Aug 24, 2012 · 8 comments

Comments

@jdemeyer
Copy link

sage-location currently only handles libraries in $SAGE_LOCAL/lib, but should also look in $SAGE_LOCAL/lib32 and $SAGE_LOCAL/lib64.

Component: relocation

Author: Jeroen Demeyer

Reviewer: John Palmieri

Merged: sage-5.4.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13397

@jdemeyer jdemeyer added this to the sage-5.4 milestone Aug 24, 2012
@jdemeyer
Copy link
Author

Attachment: 13397_relocate_lib64.patch.gz

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:4

Looks good to me. (I'm not sure how this fits in with #13432; would it be worth it to recast everything in terms of SAGE_LOCAL? At the top of the file, you could do something like this:

SAGE_ROOT      = os.path.realpath(os.environ['SAGE_ROOT'])
try:
    SAGE_LOCAL     = os.path.realpath(os.environ['SAGE_LOCAL'])
except KeyError:
    SAGE_LOCAL     = os.path.join(SAGE_ROOT, 'local')

and then use SAGE_LOCAL everywhere in the rest of the script. This belongs on another ticket, though.)

@jdemeyer
Copy link
Author

comment:5

the SAGE_LOCAL stuff is addressed by #13452.

@jdemeyer
Copy link
Author

Merged: sage-5.4.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants