A constructor for folded cube graphs

[nathanncohen]

As the title says :-)

Nathann

Apply attachment: 13809.patch

Depends on #13862

Component: graph theory

Author: Nathann Cohen

Reviewer: David Coudert

Merged: sage-5.6.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13809

[dcoudert]

Reviewer: David Coudert

[dcoudert]

comment:2

Two small remarks on this patch:

1. "is the one roduced by this method." -> "is the one produced by this method."
2. edges are added twice: (x, bar(x)) and later (bar(x), bar(bar(x))=x ). I don't know how to prevent this with simple tests without increasing current running time, but if you have some nice idea...

[dcoudert]

comment:3

Also, thanks to patch #11353, the compact version of the complement function is str(~FrozenBitset(x)), but it is slightly slower for small values of n.

[nathanncohen]

comment:4

Updated !

Nathann

[dcoudert]

comment:5

For me the patch is good to go (install, test, doc, etc.).

[jdemeyer]

comment:6

Just a reminder of something I already said on #13306: you cannot keep adding stuff forever to the file sage/graphs/graph_generators.py.

At some point, I will have to refuse such patches before that file gets really too big.

[dcoudert]

comment:7

Now that we have the generators directory, we can split the graph_generators.py file into dedicated files. Nathann will make such a patch.

[nathanncohen]

comment:8

Replying to @jdemeyer:

Just a reminder of something I already said on #13306: you cannot keep adding stuff forever to the file sage/graphs/graph_generators.py.

At some point, I will have to refuse such patches before that file gets really too big.

I still have 1.5 hours left before leaving. I'm on it :-P

Nathann

[nathanncohen]

comment:9

See #13862, still working on it. BIG patch :-P

Nathann

[jdemeyer]

Merged: sage-5.6.beta2

[jdemeyer]

Dependencies: #13862

[jdemeyer]

Attachment: 13809.patch.gz

[jdemeyer]

comment:14

Put back a sensible commit message.