Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type + code cleanup in numerical.optimize #13815

Closed
a-andre opened this issue Dec 9, 2012 · 7 comments
Closed

Fix type + code cleanup in numerical.optimize #13815

a-andre opened this issue Dec 9, 2012 · 7 comments
Assignees
@jasongrout @sagetrac-jkantor
Labels
c: numerical p: major / 3 t: enhancement
Milestone
sage-5.6

Comments

@a-andre
Copy link

a-andre commented Dec 9, 2012

It's Broyden-Fletcher-Goldfarb-Shanno not Broyden-Fletcher-Goldfarb-Shannon.

The attached patch also uses a python3 compatible syntax to raise errors.

Component: numerical

Author: André Apitzsch

Reviewer: Volker Braun

Merged: sage-5.6.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13815
@a-andre a-andre added this to the sage-5.6 milestone Dec 9, 2012
@vbraun
Copy link
Member

vbraun commented Dec 10, 2012

comment:1

Please no unnecessary whitespace changes. This only serves to break other people's patches.

@a-andre
Copy link
Author

a-andre commented Dec 10, 2012

Attachment: trac_13815.patch.gz

@a-andre
Copy link
Author

a-andre commented Dec 10, 2012

comment:2

I removed the whitespace changes. Let's hope we get rid of the trailing whitespaces when moving to git.

@a-andre

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented Dec 10, 2012

comment:3

The %-operator is deprecated in py3, so I guess we are not fully compliant. But its better than before ;-)

@vbraun
Copy link
Member

vbraun commented Dec 10, 2012

Reviewer: Volker Braun

@jdemeyer
Copy link

Merged: sage-5.6.beta2

@a-andre a-andre mentioned this issue Jan 12, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@sagetrac-jkantor sagetrac-jkantor

Labels
c: numerical p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-5.6
Development

No branches or pull requests
4 participants
@jasongrout @vbraun @jdemeyer @a-andre