Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rescale_col method of matrices should be rescale_column #13818

Open
SnarkBoojum mannequin opened this issue Dec 10, 2012 · 0 comments
Open

The rescale_col method of matrices should be rescale_column #13818

SnarkBoojum mannequin opened this issue Dec 10, 2012 · 0 comments

Comments

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Dec 10, 2012

The other pairs of methods (swap_rows/swap_columns, add_multiple_of_row/add_multiple_of_column, row_space/column_space, etc) all use the unabbreviated nouns, so I suggest renaming rescale_col to rescale_column for coherence.

I would provide a brutal patch (sed-magic), but it would certainly be worthy to add a rescale_col method which calls rescale_column and warns about the renaming before pulling the plug on the old method name -- and I don't know how to do that.

Component: linear algebra

Issue created by migration from https://trac.sagemath.org/ticket/13818

@SnarkBoojum SnarkBoojum mannequin added this to the sage-5.11 milestone Dec 10, 2012
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants