Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymmetricGroup as a proper WeylGroup #14095

Closed
nthiery opened this issue Feb 11, 2013 · 23 comments
Closed

SymmetricGroup as a proper WeylGroup #14095

nthiery opened this issue Feb 11, 2013 · 23 comments
Assignees
@sagetrac-sage-combinat
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-6.2

Comments

@nthiery
Copy link
Contributor

nthiery commented Feb 11, 2013

During Sara Billey's talk, it came up that not all of the Weyl group functionalities are available for the symmetric group:

  • The symmetric group does not implement CartanType
  • The Stanley symmetric function code uses the old fashionned W.unit() rather than W.one(). There might be some other occurences that should be cleaned up

Test case:

sage: G = SymmetricGroup(4)
sage: w = G.from_reduced_word([3,2,3,1])
sage: w.stanley_symmetric_function()
3*m[1, 1, 1, 1] + 2*m[2, 1, 1] + m[2, 2] + m[3, 1]

CC: @tscrim

Component: combinatorics

Keywords: days45, coxeter

Author: Frédéric Chapoton

Branch/Commit: b790a37

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/14095
@nthiery nthiery added this to the sage-5.11 milestone Feb 11, 2013
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

Branch: u/chapoton/14095

@fchapoton
Copy link
Contributor

Commit: c97072a

@fchapoton
Copy link
Contributor

comment:4

Here is a git branch that

  1. introduces the cartan_type method in SymmetricGroup

  2. transforms a few W.unit() into W.one()

New commits:

c97072atrac #14095 remove use of .unit ; added cartan_type for SymmetricGroup

@fchapoton
Copy link
Contributor

Changed keywords from days45 to days45, coxeter

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2014

comment:5

FYI - On my TODO list to review.

@tscrim
Copy link
Collaborator

tscrim commented Apr 5, 2014

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 5, 2014

Changed commit from c97072a to 3f77996

@tscrim
Copy link
Collaborator

tscrim commented Apr 5, 2014

Changed branch from u/chapoton/14095 to u/tscrim/14095

@tscrim
Copy link
Collaborator

tscrim commented Apr 5, 2014

comment:6

Looks good overall. I've caught one more unit in the category AffineWeylGroups. I've also marked some tests as # long time in permgroup_named.py since basic testing of that file was taking forever. Plus I've done some other tweaks to that file (gawd that file needs cleanup though). So if you're happy with my changes then positive review.

New commits:

4df5a62One more unit() to one().
3f77996Some misc cleanup to permgroup_named.py.

@fchapoton
Copy link
Contributor

comment:7

Looks good to me. But maybe one should add the "test case" in the ticket description somewhere ?

@fchapoton
Copy link
Contributor

comment:8

I have added a doctest and taken the opportunity to correct the reference section. I agree with your previous changes. If you agree with mines, please set to positive review.

New commits:

8495839trac #14095 added the new example from the trac ticket

@fchapoton
Copy link
Contributor

Changed commit from 3f77996 to 8495839

@fchapoton
Copy link
Contributor

Changed branch from u/tscrim/14095 to u/chapoton/14095

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

5f08858correct formatting of doc and raise syntax for python3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2014

Changed commit from 8495839 to 5f08858

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2014

Changed commit from 5f08858 to 1573f6b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

1573f6bmore doc correction

@tscrim
Copy link
Collaborator

tscrim commented Apr 7, 2014

comment:11

Could you also change that \dots into \cdots? With that, you can set positive review on my behalf. Thanks Frederic.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 8, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

b790a37trac #14095 cdots instead of dots

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 8, 2014

Changed commit from 1573f6b to b790a37

@fchapoton
Copy link
Contributor

comment:13

Done.

@vbraun
Copy link
Member

vbraun commented Apr 8, 2014

Changed branch from u/chapoton/14095 to b790a37

@vbraun vbraun closed this as completed in fd77889 Apr 8, 2014
tscrim pushed a commit to tscrim/sage that referenced this issue Jun 1, 2023
Merge branch 'develop' into public/algebras/fp_algebras
05381a3 
* develop: (181 commits)
  Updated Sage version to 6.2.beta7
  Improve the deprecated_function_alias
  trac sagemath#14095 cdots instead of dots
  Set() with no argument returns an empty Set.
  more doc correction
  correct formatting of doc and raise syntax for python3
  trac sagemath#14095 added the new example from the trac ticket
  Matplotlib depends on pkgconf, not the pkgconfig python module
  Fixed indentation.
  changed the forward slash to backslash for MatLab operator
  Fixed appearence of int in chord_and_tangent
  fix formula in comment
  Trac 15737: small correction
  DiGraph.is_aperiodic: Add Wikipedia link to docstring
  DiGraph.is_aperiodic: new method (wraps networkx method)
  Trac 15737: fixing the supersingular case, too
  Trac 15737: adjusting the ordinary case
  Some misc cleanup to permgroup_named.py.
  One more unit() to one().
  Trac sagemath#15737: Error relating to precision in sha_tate
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-sage-combinat sagetrac-sage-combinat

Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
5 participants
@nthiery @vbraun @tscrim @jdemeyer @fchapoton