Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tournament and directed path constructors #14122

Closed
nathanncohen mannequin opened this issue Feb 14, 2013 · 9 comments
Closed

Tournament and directed path constructors #14122

nathanncohen mannequin opened this issue Feb 14, 2013 · 9 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Feb 14, 2013

Implements a constructor for Tournament and directed paths. This may be useful in #14099.

CC: @dcoudert

Component: graph theory

Author: Nathann Cohen

Reviewer: David Coudert

Merged: sage-5.8.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14122

@nathanncohen nathanncohen mannequin added this to the sage-5.8 milestone Feb 14, 2013
@nathanncohen nathanncohen mannequin added the s: needs review label Feb 14, 2013
@dcoudert
Copy link
Contributor

comment:2

Some remarks:

  • Returns the De Bruijn diraph with parameters k,n. -> Returns the De Bruijn digraph with parameters k,n.

  • in both functions, the statement g = DiGraph() should be after the test on n

  • Returns a tournament n vertices. -> Returns a tournament on n vertices. (twice in patch)

  • for i in range(n) -> for i in range(n-1)

  • d = {i:(i,0) for i in range(n)}

    g.set_pos(d)

    -> g.set_pos( {i:(i,0) for i in range(n)} )

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 14, 2013

comment:3

Hahahaha. It all makes sense. Thank you ! :-)

Nathann

@dcoudert
Copy link
Contributor

comment:4

The patch is working (install, tests, docbuild) and good to go.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 15, 2013

comment:5

Thaaaaaaaaaanks ! :-)

Nathann

@jdemeyer
Copy link

comment:6

The patch needs a proper commit message.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 19, 2013

Attachment: trac_14122.patch.gz

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 19, 2013

comment:7

Argggggg ! I knew that I had forgotten a commit message in some ticket ! Sorryyyyyyyy ^^;

Nathann

@jdemeyer
Copy link

Merged: sage-5.8.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants