Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very bad mistakes in linear_arboricity #14128

Closed
nathanncohen mannequin opened this issue Feb 15, 2013 · 7 comments
Closed

Very bad mistakes in linear_arboricity #14128

nathanncohen mannequin opened this issue Feb 15, 2013 · 7 comments
Assignees
@jasongrout @rlmill @nathanncohen
Labels
c: graph theory p: major / 3 t: bug
Milestone
sage-5.8

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Feb 15, 2013

linear_arboricity has a parameter k which appears to define the number of colors, but does not. This patch renames is to plus_one. Plus the function did not compute the decomposition with a minimum number of colors.
Plus Andrew Juell reported "a counter example to a very old conjecture" which turns out to be a Sage bug ! Too bad :-)

Nathann

CC: @dcoudert

Component: graph theory

Author: Nathann Cohen

Reviewer: David Coudert

Merged: sage-5.8.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14128
@nathanncohen nathanncohen mannequin added this to the sage-5.8 milestone Feb 15, 2013
@nathanncohen nathanncohen mannequin added the s: needs review label Feb 15, 2013
@dcoudert
Copy link
Contributor

comment:2

The patch is working but you could change the following text

  • "`plus_one`` (integer) -- the number of colors to use."

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 15, 2013

comment:3

What about that ? :-)

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 15, 2013

Attachment: trac_14128.patch.gz

@dcoudert
Copy link
Contributor

comment:4

Much better !

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 15, 2013

comment:5

Thaaaaaaaaaaaaaaanks !!

Nathann

@jdemeyer
Copy link

Merged: sage-5.8.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@rlmill rlmill

@nathanncohen nathanncohen

Labels
c: graph theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-5.8
Development

No branches or pull requests
3 participants
@jasongrout @jdemeyer @dcoudert