Sylvester and Sims-Gewirtz graphs

[nathanncohen]

As the title says. Two other graphs from http://www.win.tue.nl/~aeb/graphs/index.html

Nathann

CC: @dimpase

Component: graph theory

Author: Nathann Cohen

Reviewer: Frédéric Chapoton

Merged: sage-5.9.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14271

[fchapoton]

comment:2

Hello,

• maybe add a link to :wikipedia:`Gewirtz graph` ?

• the plots are random and not very nice

• there should be two :: after SEEALSO

[nathanncohen]

comment:3

Hellooooooooo !!

• maybe add a link to :wikipedia:`Gewirtz graph` ?

Done.

• the plots are random and not very nice

Yes I know, but I was not able to build one that I liked, so.. :-P

• there should be two :: after SEEALSO

Done !

Nathann

[fchapoton]

Attachment: trac_14271-review-fc.patch.gz

[fchapoton]

comment:4

Hello,

once the bot is green again, and if you agree with my review patch, you can set a positive review

[dimpase]

comment:5

OK, this one goes in first, then! Rebase the rest of stuff pending in age/graphs/generators/smallgraphs.py.

[nathanncohen]

Attachment: trac_14271-layouts.patch.gz

[nathanncohen]

comment:6

Hello guys ! I improved my drawing scripts and ended up finding two nice layouts for these graphs. I hope that you will not mind my setting this ticket back to "needs_review", if only for a very short patch :-)

Nathann

[fchapoton]

comment:8

ok, looks better indeed. Back to positive review

[fchapoton]

Reviewer: Frédéric Chapoton

[nathanncohen]

comment:9

Thaaaaaaaaaaaaaaaanks ! :-)

Nathann

[jdemeyer]

comment:10

dochtml.log:[graphs   ] /padic/release/merger/sage-5.9.beta2/local/lib/python2.7/site-packages/sage/graphs/graph_generators.py:docstring of sage.graphs.graph_generators.GraphGenerators.SimsGewirtzGraph:8: ERROR: Unknown target name: "http://www.win.tue.nl/~aeb/graphs/sims-gewirtz.html".
dochtml.log:[graphs   ] /padic/release/merger/sage-5.9.beta2/local/lib/python2.7/site-packages/sage/graphs/graph_generators.py:docstring of sage.graphs.graph_generators.GraphGenerators.SylvesterGraph:7: ERROR: Unknown target name: "http://www.win.tue.nl/~aeb/graphs/sylvester.html".

[jdemeyer]

Work Issues: documentation

[nathanncohen]

Attachment: trac_14271.patch.gz

[nathanncohen]

comment:11

Apply trac_14271.patch, trac_14271-review-fc.patch, trac_14271-layouts.patch

[nathanncohen]

comment:12

Sorryyyyyyyyy, I just updated it !

Nathann

[jdemeyer]

Changed work issues from documentation to none

[jdemeyer]

Merged: sage-5.9.beta2