New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cliquer does not like the empty graph #14525
Comments
comment:1
I am an idiot -_- Nathann |
comment:2
Nobody seemed to be working on this, so I quickly fixed it. I also fixed the method to get all maximum cliques. I didn't add my name to the authors, since this is just a minor bug fix. I don't know the policy on this. I'm sure that I can be found through the versioning system, if at some point I need to be blamed for introducing a bug. |
comment:3
Why would you return Wouldn't return And even short bugfixes have authors, and even there the author is the one who writes the patch. Soooooooooooooooo Nathann |
comment:4
I actually copied the patch for #10756, which returns |
comment:5
If you can, it would be nice indeed Nathann |
As requested |
comment:6
Attachment: trac_14525_cliquer_empty.patch.gz btw, the tests actually test methods different from these functions but which use those functions. I guessed this was OK, because that was also the way it was done for |
comment:7
Hmmmmmm... It is correct most of the time, because sage -coverage notices that the function's name is the same, but that does not work for
I just uploaded a small patch that fixes that. If you agree with it, then you can set this ticket to Nathann |
Reviewer: Nathann Cohen |
Author: Nico Van Cleemput |
comment:8
Attachment: trac_14525-rev.patch.gz OK, looks ok and works for me. |
Merged: sage-5.10.rc1 |
Stupid corner case but still worth fixing. Asking for the clique number of the empty graph blows Sage off.
Simply checking if the supplied graph is empty is going to fix this for sure.
CC: @nathanncohen
Component: graph theory
Author: Nico Van Cleemput
Reviewer: Nathann Cohen
Merged: sage-5.10.rc1
Issue created by migration from https://trac.sagemath.org/ticket/14525
The text was updated successfully, but these errors were encountered: