Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

McLaughlin graph constructor #14547

Closed
nathanncohen mannequin opened this issue May 7, 2013 · 8 comments
Closed

McLaughlin graph constructor #14547

nathanncohen mannequin opened this issue May 7, 2013 · 8 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 7, 2013

Annnnnnnnnnnd I think that this is the last one I can steal from www.win.tue.nl/~aeb/ without help in maths ^^;

The tests are rather long, but they are not flagged with "long time". This is because they are already flagged with "optional gap_packages", and

  1. I have no idea how flags should be stacked in such situations
  2. with an "optional" flag the doctests will be almost never run, so let's not make it even rarer :-P

And. I computed some layouts for this graph, all of them looking like a giant black thing. That was in png. I also tried svg, and you can check at this address (if you can display it :-P) what we are missing by not adding the layout to Sage's constructor :

http://www.steinertriples.fr/10.svg
http://www.steinertriples.fr/11.svg
http://www.steinertriples.fr/26.svg

Nathann

CC: @rbeezer

Component: graph theory

Author: Nathann Cohen

Reviewer: Frédéric Chapoton

Merged: sage-5.12.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14547

@nathanncohen nathanncohen mannequin added this to the sage-5.11 milestone May 7, 2013
@nathanncohen

This comment has been minimized.

@nathanncohen nathanncohen mannequin added the s: needs review label May 7, 2013
@fchapoton
Copy link
Contributor

comment:3

Attachment: trac_14547.patch.gz

looks good to me. I have made cosmetic changes (pep8) in my review patch.

If you are happy with that, you can set a positive review.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 8, 2013

comment:4

Excellent ! Thank you very much :-)

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 8, 2013

Reviewer: Frédéric Chapoton

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Jul 21, 2013
@jdemeyer
Copy link

comment:6

The reviewer patch needs a proper commit message.

@fchapoton
Copy link
Contributor

Attachment: trac_14547_review.patch.gz

@fchapoton
Copy link
Contributor

comment:7

commit message added

@jdemeyer
Copy link

Merged: sage-5.12.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants